Skip to content

Fix segfault #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kaushik Raina (k-raina) wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix segfault #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4a8baf
tmp
k-raina Jan 6, 2026
4a4e155
tmp
k-raina Jan 6, 2026
7f845e1
tmp
k-raina Jan 6, 2026
9f16920
tmp
k-raina Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 130 additions & 0 deletions .semaphore/semaphore.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,136 @@ blocks:
- bash -c '../../ci/tests/run_perf_test.sh'
- rm -rf ./node_modules

- name: "PR Artifacts: Linux amd64"
run:
when: "branch != 'master' AND tag !~ '^v[0-9]\\.' AND change_in(['/package.json', '/lib', '/src'])"
dependencies: [ ]
task:
agent:
machine:
type: s1-prod-ubuntu24-04-amd64-1
env_vars:
- name: ARCHITECTURE
value: "x64"
- name: PLATFORM
value: "linux"
- name: LIBC
value: "glibc"
prologue:
commands:
- '[[ -z $DOCKERHUB_APIKEY ]] || docker login --username $DOCKERHUB_USER --password $DOCKERHUB_APIKEY'
jobs:
- name: "Build PR Artifact"
matrix:
- env_var: NODE_VERSION_ABI
values:
- 20,115
- 22,127
commands:
- export NODE_VERSION=$(echo $NODE_VERSION_ABI | cut -d, -f1)
- export NODE_ABI=$(echo $NODE_VERSION_ABI | cut -d, -f2)
- export PR_ID="pr-${SEMAPHORE_GIT_BRANCH}-${SEMAPHORE_GIT_SHA:0:7}"
- export PKG_VERSION=$(node -p "require('./package.json').version")
- .semaphore/docker_run_with_volumes.sh node:${NODE_VERSION}-bullseye /v/.semaphore/build-docker-debian.sh
- export ARTIFACT_KEY="confluent-kafka-javascript-${PKG_VERSION}-node-v${NODE_ABI}-${PLATFORM}-${LIBC}-${ARCHITECTURE}.tar.gz"
- ls build/stage/${PKG_VERSION}/${ARTIFACT_KEY}
- artifact push workflow "build/stage/${PKG_VERSION}/${ARTIFACT_KEY}" --destination "pr-artifacts/${PR_ID}/${ARTIFACT_KEY}"

- name: "PR Artifacts: Linux amd64 (musl)"
run:
when: "branch != 'master' AND tag !~ '^v[0-9]\\.' AND change_in(['/package.json', '/lib', '/src'])"
dependencies: [ ]
task:
agent:
machine:
type: s1-prod-ubuntu24-04-amd64-1
env_vars:
- name: ARCHITECTURE
value: "x64"
- name: PLATFORM
value: "linux"
- name: LIBC
value: "musl"
prologue:
commands:
- '[[ -z $DOCKERHUB_APIKEY ]] || docker login --username $DOCKERHUB_USER --password $DOCKERHUB_APIKEY'
jobs:
- name: "Build PR Artifact"
matrix:
- env_var: NODE_VERSION_ABI
values:
- 20,115
- 22,127
commands:
- export NODE_VERSION=$(echo $NODE_VERSION_ABI | cut -d, -f1)
- export NODE_ABI=$(echo $NODE_VERSION_ABI | cut -d, -f2)
- export PR_ID="pr-${SEMAPHORE_GIT_BRANCH}-${SEMAPHORE_GIT_SHA:0:7}"
- export PKG_VERSION=$(node -p "require('./package.json').version")
- .semaphore/docker_run_with_volumes.sh node:${NODE_VERSION}-alpine /v/.semaphore/build-docker-alpine.sh
- export ARTIFACT_KEY="confluent-kafka-javascript-${PKG_VERSION}-node-v${NODE_ABI}-linux-${LIBC}-${ARCHITECTURE}.tar.gz"
- ls build/stage/${PKG_VERSION}/${ARTIFACT_KEY}
- artifact push workflow "build/stage/${PKG_VERSION}/${ARTIFACT_KEY}" --destination "pr-artifacts/${PR_ID}/${ARTIFACT_KEY}"

- name: "PR Artifacts: macOS arm64"
run:
when: "branch != 'master' AND tag !~ '^v[0-9]\\.' AND change_in(['/package.json', '/lib', '/src'])"
dependencies: []
task:
agent:
machine:
type: s1-macos-15-arm64-8
env_vars:
- name: ARCHITECTURE
value: "arm64"
- name: PLATFORM
value: "darwin"
- name: LIBC
value: "unknown"
jobs:
- name: "Build PR Artifact"
matrix:
- env_var: NODE_VERSION_ABI
values:
- 20,115
- 22,127
commands:
- export NODE_VERSION=$(echo $NODE_VERSION_ABI | cut -d, -f1)
- export NODE_ABI=$(echo $NODE_VERSION_ABI | cut -d, -f2)
- sem-version node $NODE_VERSION
- export PR_ID="pr-${SEMAPHORE_GIT_BRANCH}-${SEMAPHORE_GIT_SHA:0:7}"
- export PKG_VERSION=$(node -p "require('./package.json').version")
- npm ci
- npx node-pre-gyp package
- export ARTIFACT_KEY="confluent-kafka-javascript-${PKG_VERSION}-node-v${NODE_ABI}-${PLATFORM}-${LIBC}-${ARCHITECTURE}.tar.gz"
- ls build/stage/${PKG_VERSION}/${ARTIFACT_KEY}
- artifact push workflow "build/stage/${PKG_VERSION}/${ARTIFACT_KEY}" --destination "pr-artifacts/${PR_ID}/${ARTIFACT_KEY}"

- name: "PR Artifacts: Summary"
dependencies:
- "PR Artifacts: Linux amd64"
- "PR Artifacts: Linux amd64 (musl)"
- "PR Artifacts: macOS arm64"
run:
when: "branch != 'master' AND tag !~ '^v[0-9]\\.' AND change_in(['/package.json', '/lib', '/src'])"
task:
agent:
machine:
type: s1-prod-ubuntu24-04-amd64-1
jobs:
- name: "List PR Artifacts"
commands:
- export PR_ID="pr-${SEMAPHORE_GIT_BRANCH}-${SEMAPHORE_GIT_SHA:0:7}"
- artifact pull workflow pr-artifacts/${PR_ID}
- echo "=== PR Artifacts Available for Download ==="
- 'echo "PR ID: $PR_ID"'
- 'echo "Branch: $SEMAPHORE_GIT_BRANCH"'
- 'echo "Commit: $SEMAPHORE_GIT_SHA"'
- echo ""
- echo "Available artifacts:"
- bash -c 'if [ -d "pr-artifacts/$PR_ID" ]; then find pr-artifacts/$PR_ID -name "*.tar.gz" -type f -exec basename {} \; | sed "s/^/ - /"; else echo " No artifacts found (may still be building)"; fi'
- echo ""
- echo "Download artifacts from Semaphore CI workflow artifacts section"

- name: "Linux amd64: Release"
dependencies: [ ]
run:
Expand Down
2 changes: 1 addition & 1 deletion lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ util.dictToStringList = function (mapOrObject) {
return list;
};

util.bindingVersion = '1.8.0';
util.bindingVersion = '1.8.0-test';
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version suffix '-test' is unconventional and inconsistent with the schemaregistry package which uses '1.8.0'. These version strings should match or follow standard semantic versioning conventions.

Suggested change
util.bindingVersion = '1.8.0-test';
util.bindingVersion = '1.8.0';

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@confluentinc/kafka-javascript",
"version": "1.8.0",
"version": "1.8.0-test",
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version suffix '-test' is unconventional for production releases. Standard semantic versioning uses suffixes like '-alpha', '-beta', or '-rc' for pre-release versions. Consider using '1.8.0' for the final release or a standard pre-release identifier.

Suggested change
"version": "1.8.0-test",
"version": "1.8.0",

Copilot uses AI. Check for mistakes.
"description": "Node.js bindings for librdkafka",
"librdkafka": "2.13.0",
"librdkafka_win": "2.13.0",
Expand Down