Repository navigation
test: CI workflow and Saloon-mocked Pest coverage - #11
Draft
jordanpartridge wants to merge 2 commits into
Draft
jordanpartridge wants to merge 2 commits into
jordanpartridge wants to merge 2 commits into
Conversation
jordanpartridge
force-pushed
the
cursor/ci-pest-coverage-6412
branch
from
September 10, 2026 05:55
ffd35f0 to
d582cd9
Compare
Wire GitHub Actions (PHP 8.3, composer, pint --test, pest), add composer test/lint scripts, and replace scaffold tests with Saloon-mocked feature coverage for zones/DNS/tunnel commands plus CloudflareConnector unit tests. Refresh the lockfile for PHP 8.3-compatible dependencies. Co-authored-by: Jordan Partridge <jordan@partridge.rocks>
Co-authored-by: Jordan Partridge <jordan@partridge.rocks>
cursor
Bot
force-pushed
the
cursor/ci-pest-coverage-6412
branch
from
September 13, 2026 00:46
4f3d7f8 to
b6a4b9a
Compare
There was a problem hiding this comment.
Ship it.
- All new feature tests use Saloon mocks, cover success + error + JSON paths, and the shared Pest hooks clean up state correctly.
- Composer scripts and PHP 8.3 lockfile changes are minimal and correct.
- One small inconsistency in TunnelDeleteCommandTest (manual destroyGlobal in one test) but it does not affect correctness.
- No blocking issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased onto latest
main. Keeps main’s quality-runners–aware CI workflow; adds Saloon-mocked Pest coverage for zones/DNS/tunnel commands plus connector unit tests.Test plan
vendor/bin/pestlocally (58 passed)