test: add test for withdraw() at same timestamp as resume() - #278
Open
GazzyLee wants to merge 1 commit into
Open
test: add test for withdraw() at same timestamp as resume()#278GazzyLee wants to merge 1 commit into
GazzyLee wants to merge 1 commit into
Conversation
Add a dedicated test that calls withdraw() in the exact same ledger timestamp as resume() to guard against off-by-one errors in elapsed-time math. The test asserts that the withdrawable amount correctly reflects zero newly-streamed tokens at that instant. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
@GazzyLee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a dedicated
withdraw_at_same_timestamp_as_resume()test totests/stream_pause_resume.rs.This test covers calling
withdraw()at the exact same ledger timestamp asresume(), with zero elapsed seconds since the stream was resumed.It verifies that the withdrawable amount correctly reflects zero newly streamed tokens at that instant.
Motivation
None of the existing tests in
stream_pause_resume.rscovered the edge case of callingwithdraw()at the exact same timestamp asresume().This dedicated test guards against potential off-by-one errors in the elapsed-time calculation by ensuring that when a withdrawal occurs immediately after resuming, with no time elapsed, only the tokens accumulated before the pause are withdrawable.
Test Details
The new test:
withdraw()at the exact same ledger timestamp asresume(), without callingadvance().Test Results
All 8 tests in
stream_pause_resume.rspass, including the new test: