fix(ai): strip trailing newlines and whitespace from provider API keys (#1437) - #1438
Open
Shubh2-0 wants to merge 1 commit into
Open
fix(ai): strip trailing newlines and whitespace from provider API keys (#1437)#1438Shubh2-0 wants to merge 1 commit into
Shubh2-0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1437
Description
When provider API keys or env vars are loaded from secrets, .env files or command line expansions (e.g. cat keyfile), they often contain trailing newlines (\n) or surrounding whitespace. When passed into HTTP client Authorization headers, Java HTTP clients reject the raw 0x0a newline byte and throw 'Unexpected char 0x0a in Authorization value'.
Changes Made
Verification