Skip to content

Remove code coverage from codecov - #108

Merged
mp-orkes merged 1 commit into
mainfrom
ci/disable-codecov-comment
Aug 7, 2026
Merged

Remove code coverage from codecov#108
mp-orkes merged 1 commit into
mainfrom
ci/disable-codecov-comment

Conversation

@kowser-orkes

Copy link
Copy Markdown
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

  • remove the Codecov upload step

Alternatives considered

  • keep Codecov and just silence its PR comment

@mp-orkes mp-orkes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upload is gone, is -coverprofile=coverage.out -covermode=atomic on line 35 still worth keeping? Nothing reads the file anymore.

@kowser-orkes
kowser-orkes force-pushed the ci/disable-codecov-comment branch from a8e87a0 to 1c69fc2 Compare August 6, 2026 16:16
@kowser-orkes

kowser-orkes commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Removed those reference as well

@mp-orkes
mp-orkes merged commit 6b48124 into main Aug 7, 2026
5 of 8 checks passed
@mp-orkes
mp-orkes deleted the ci/disable-codecov-comment branch August 7, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants