Repository navigation
feat(models): add Gemini 3.5 Flash and Flash Lite to LLMType (release with backend #3070 deploy) - #61
Draft
John Xing (johnxing-amigo) wants to merge 1 commit into
Draft
John Xing (johnxing-amigo) wants to merge 1 commit into
John Xing (johnxing-amigo) wants to merge 1 commit into
Conversation
Mirrors backend #3070, which adds google_gemini-3.5-flash and google_gemini-3.5-flash-lite to LLMType and keeps the 2.5 ids. Without it, LLMConfigInput rejects a 3.5 id client-side before the request is sent. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
Found 27 test failures on Blacksmith runners: Failures
...and 17 more test failures. View all on Blacksmith
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend #3070 adds
google_gemini-3.5-flashandgoogle_gemini-3.5-flash-litetoLLMTypeand keeps the 2.5 ids. On 2.0.1,LLMConfigInput(llm_name="google_gemini-3.5-flash")raises aValidationErrorclient-side, so nobody can pin 3.5 through the SDK.What changes
specs/openapi-baseline.json: two values appended tocomponents.schemas.LLMType.enum. Nothing else in the snapshot moves.src/amigo_sdk/generated/model.py: regenerated withscripts/gen_models.py. OnlyLLMType.google_gemini_3_5_flashandgoogle_gemini_3_5_flash_liteare new.tests/test_current_contract_models.py:LLMConfigInputaccepts both 3.5 ids.Review
lib/amigo_lib/llm/llm.pyin values and order.Test plan
ruff check .,ruff format --check .,mypy src/amigo_sdk/pytest: 202 passed, 8 skipped, 88.46% coveragecurl -s https://api.amigo.ai/v1/openapi.json | jq .components.schemas.LLMType.enumlists both 3.5 ids, then mergegh workflow run release.yml --repo concurrence-hq/amigo-python-sdk --ref main -f version_type=minor. Leaveregenerate_models=falseso it ships the committed models. The auto path waits on backend notify-sdk pointing at concurrence-hq.Rollout: PyPI minor (2.1.0) via manual
release.yml. Roll back by yanking the version and releasing a revert.Not in this PR: repository and docs URLs (#60, Caly), and the post-#3071 release that removes 2.5.