security: patch brace-expansion and postcss advisories via overrides - #2933
security: patch brace-expansion and postcss advisories via overrides#2933lbondaryk wants to merge 1 commit into
Conversation
Force patched versions of two transitively-pulled packages flagged by npm audit: - brace-expansion -> ^5.0.8. The newest advisory (GHSA-mh99, OOM via unbounded expansion) is only fixed in 5.0.8; the 1.x/2.x lines pulled by minimatch remain vulnerable. Overriding to 5.0.8 dedupes the tree to a single patched copy. - postcss -> ^8.5.18 (resolves to 8.5.23). styled-components pins postcss to exactly 8.4.31, which blocked a normal update; the override lifts every consumer to a patched 8.5.x (all accept ^8). Both are build/tooling-time dependencies. npm audit clears both; webpack build, typecheck, and jest all pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses npm audit advisories by adding npm overrides to force patched transitive versions of brace-expansion and postcss, updating the lockfile accordingly so the dependency tree dedupes onto the patched copies.
Changes:
- Add npm
overridesforbrace-expansionandpostcssto force patched versions across the dependency tree. - Regenerate
package-lock.jsonto reflect the resolved patched versions (including related transitive updates likenanoidandsource-map-js).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Adds overrides entries to force patched versions of brace-expansion and postcss. |
| package-lock.json | Updates the resolved dependency graph to use brace-expansion@5.0.8 and postcss@8.5.23, removing older vulnerable copies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "overrides": { | ||
| "mobx-state-tree": "npm:@concord-consortium/mobx-state-tree@6.0.0-cc.1", | ||
| "@cortex-js/compute-engine": "npm:@concord-consortium/compute-engine@0.12.3-cc.1" | ||
| "@cortex-js/compute-engine": "npm:@concord-consortium/compute-engine@0.12.3-cc.1", | ||
| "brace-expansion": "^5.0.8", | ||
| "postcss": "^8.5.18" |
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
security-deps-brace-expansion-postcss
|
| Run status |
|
| Run duration | 10m 23s |
| Commit |
|
| Committer | Leslie Bondaryk |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
1
|
|
|
5
|
|
|
0
|
|
|
220
|
| View all changes introduced in this branch ↗︎ | |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
- Coverage 85.86% 85.85% -0.02%
==========================================
Files 957 957
Lines 54527 54527
Branches 14357 14357
==========================================
- Hits 46822 46815 -7
- Misses 7687 7694 +7
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
scytacki
left a comment
There was a problem hiding this comment.
The GitHub build is failing.
The dependencies-notes.md file should be updated to indicate why these are being overridden to these versions.
Claude should review the Copilot comment and decide if what it thinks and respond to comment.
Force patched versions of two transitively-pulled packages flagged by npm audit:
Both are build/tooling-time dependencies. npm audit clears both; webpack build, typecheck, and jest all pass.