Skip to content

security: patch brace-expansion and postcss advisories via overrides - #2933

Open
lbondaryk wants to merge 1 commit into
masterfrom
security-deps-brace-expansion-postcss
Open

security: patch brace-expansion and postcss advisories via overrides#2933
lbondaryk wants to merge 1 commit into
masterfrom
security-deps-brace-expansion-postcss

Conversation

@lbondaryk

Copy link
Copy Markdown
Contributor

Force patched versions of two transitively-pulled packages flagged by npm audit:

  • brace-expansion -> ^5.0.8. The newest advisory (GHSA-mh99, OOM via unbounded expansion) is only fixed in 5.0.8; the 1.x/2.x lines pulled by minimatch remain vulnerable. Overriding to 5.0.8 dedupes the tree to a single patched copy.
  • postcss -> ^8.5.18 (resolves to 8.5.23). styled-components pins postcss to exactly 8.4.31, which blocked a normal update; the override lifts every consumer to a patched 8.5.x (all accept ^8).

Both are build/tooling-time dependencies. npm audit clears both; webpack build, typecheck, and jest all pass.

Force patched versions of two transitively-pulled packages flagged by npm audit:

- brace-expansion -> ^5.0.8. The newest advisory (GHSA-mh99, OOM via unbounded
  expansion) is only fixed in 5.0.8; the 1.x/2.x lines pulled by minimatch remain
  vulnerable. Overriding to 5.0.8 dedupes the tree to a single patched copy.
- postcss -> ^8.5.18 (resolves to 8.5.23). styled-components pins postcss to
  exactly 8.4.31, which blocked a normal update; the override lifts every consumer
  to a patched 8.5.x (all accept ^8).

Both are build/tooling-time dependencies. npm audit clears both; webpack build,
typecheck, and jest all pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses npm audit advisories by adding npm overrides to force patched transitive versions of brace-expansion and postcss, updating the lockfile accordingly so the dependency tree dedupes onto the patched copies.

Changes:

  • Add npm overrides for brace-expansion and postcss to force patched versions across the dependency tree.
  • Regenerate package-lock.json to reflect the resolved patched versions (including related transitive updates like nanoid and source-map-js).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Adds overrides entries to force patched versions of brace-expansion and postcss.
package-lock.json Updates the resolved dependency graph to use brace-expansion@5.0.8 and postcss@8.5.23, removing older vulnerable copies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines 145 to +149
"overrides": {
"mobx-state-tree": "npm:@concord-consortium/mobx-state-tree@6.0.0-cc.1",
"@cortex-js/compute-engine": "npm:@concord-consortium/compute-engine@0.12.3-cc.1"
"@cortex-js/compute-engine": "npm:@concord-consortium/compute-engine@0.12.3-cc.1",
"brace-expansion": "^5.0.8",
"postcss": "^8.5.18"
@cypress

cypress Bot commented Jul 27, 2026

Copy link
Copy Markdown

collaborative-learning    Run #19556

Run Properties:  status check passed Passed #19556  •  git commit 6f8e114735: security: patch brace-expansion and postcss advisories via overrides
Project collaborative-learning
Branch Review security-deps-brace-expansion-postcss
Run status status check passed Passed #19556
Run duration 10m 23s
Commit git commit 6f8e114735: security: patch brace-expansion and postcss advisories via overrides
Committer Leslie Bondaryk
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 220
View all changes introduced in this branch ↗︎

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.85%. Comparing base (4fc50e8) to head (6f8e114).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2933      +/-   ##
==========================================
- Coverage   85.86%   85.85%   -0.02%     
==========================================
  Files         957      957              
  Lines       54527    54527              
  Branches    14357    14357              
==========================================
- Hits        46822    46815       -7     
- Misses       7687     7694       +7     
  Partials       18       18              
Flag Coverage Δ
cypress ?
cypress-regression 72.13% <ø> (-0.01%) ⬇️
cypress-smoke 41.55% <ø> (-0.01%) ⬇️
jest 55.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lbondaryk
lbondaryk requested a review from scytacki July 27, 2026 15:29

@scytacki scytacki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GitHub build is failing.

The dependencies-notes.md file should be updated to indicate why these are being overridden to these versions.

Claude should review the Copilot comment and decide if what it thinks and respond to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants