-
Notifications
You must be signed in to change notification settings - Fork 0
fix(cli): init ships conciv skills — claude-connect plugin skills dir + @conciv/skills via @conciv/it #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@conciv/cli': patch | ||
| --- | ||
|
|
||
| conciv init ships the conciv skills: natively in the claude-connect plugin and via @conciv/skills for intent discovery |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import {readdirSync, readFileSync} from 'node:fs' | ||
| import {createRequire} from 'node:module' | ||
| import {dirname, join, relative} from 'node:path' | ||
| import type {HarnessConnectFile} from '@conciv/protocol/harness-types' | ||
|
|
||
| export const CLAUDE_CONNECT_SKILLS_DIR = 'skills' | ||
|
|
||
| const AUTHORING_DIR = '_artifacts' | ||
|
|
||
| function skillsSourceDir(): string { | ||
| const packageManifest = createRequire(import.meta.url).resolve('@conciv/skills/package.json') | ||
| return join(dirname(packageManifest), 'skills') | ||
| } | ||
|
|
||
| function sortedEntries(dir: string): string[] { | ||
| return readdirSync(dir, {withFileTypes: true}) | ||
| .flatMap((entry) => { | ||
| const full = join(dir, entry.name) | ||
| if (entry.isDirectory()) return sortedEntries(full) | ||
| return [full] | ||
| }) | ||
| .toSorted() | ||
| } | ||
|
|
||
| function skillDirs(root: string): string[] { | ||
| return readdirSync(root, {withFileTypes: true}) | ||
| .filter((entry) => entry.isDirectory() && entry.name !== AUTHORING_DIR) | ||
| .map((entry) => entry.name) | ||
| .toSorted() | ||
| } | ||
|
|
||
| export function claudeConnectSkillFiles(pluginDir: string): HarnessConnectFile[] { | ||
| const root = skillsSourceDir() | ||
| return skillDirs(root).flatMap((skill) => | ||
| sortedEntries(join(root, skill)).map((file) => ({ | ||
| path: join(pluginDir, CLAUDE_CONNECT_SKILLS_DIR, relative(root, file)), | ||
| contents: readFileSync(file, 'utf8'), | ||
| })), | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Compare the complete published skill tree.
These assertions cover only four hard-coded
SKILL.mdpaths, one reference path, and one content sample. They pass if another published skill or reference is omitted. They also pass if a non-sampled file has altered contents.Build an independent expected path-and-content list from the published
@conciv/skillstree, exclude_artifacts, and compare it with the generated skill entries in order. This will verify file coverage, byte-preserving contents, exclusions, and deterministic ordering.🤖 Prompt for AI Agents