Repository navigation
Give each skill its own APM package and version - #51
CodyCBakerPhD wants to merge 11 commits into
Conversation
Each skills/<name>/apm.yml declares the skill's name, version and description, so APM can record a skill's own version. Skills with a frontmatter version keep it; the rest start at 0.1.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
Validate each skill's apm.yml and its agreement with a frontmatter version (E010, E011), install each skill as its own package in the apm check, list missing <name>--v<version> release tags, and document the install form, versioning and tagging. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
Separate calls leave target: legacy deployments in the lock, which the frozen restore then rewrites. Tell consumers the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
This reverts commit 8a74a96. #51 rewrites the AGENTS.md "Skill versions" section, which covers this sentence, so this pull request stays limited to setup-chromatic. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw3QuYxA1bV48ZgQcor
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
A consumer pinning a commit already gets the skill's version from its apm.yml, so a merged version bump needs no release tags. Remove ci/skill_tags.py and the Release tags section; note that semver refs would need <name>--v<version> tags, which this repository does not publish. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
yarikoptic-gitmate
left a comment
There was a problem hiding this comment.
Thanks @CodyCBakerPhD. Reviewed at 24ad45f (still a draft, so take this as early feedback). The approach holds up: the PR's claims about apm-cli 0.31.0 were checked against its source and by running it, and a per-skill apm.yml is the only way 0.31 records a per-skill version in the lock. CI is green, and tox -e validate,apm plus ci/check_apm.py --source con/skills#b4205e8… pass locally. Dropping the tagging procedure in 24ad45f made the PR leaner.
Inline, most important first:
- Keep the root
apm.yml. It coexists with the per-skill manifests, spares existing consumers a lock change, and removes text and a special case from this PR. apm updatemoves a commit pin back to the bare tag0.20261015.0, a commit where most skills do not exist. Not new, but commit pins are now the only documented form. Delete the tag or warn.- Two-line manifests:
descriptionandtype: skillare not used by APM, and 21 of 25 descriptions already differ from theirSKILL.md. - Bump rule:
install-apm-skillsandauthor-apm-skillschange procedure here but stay at0.1.0. - Three nits in
ci/.
Outside the diff, text this PR makes stale:
skills/code-quality-report-conventions/SKILL.md:17still gives the root form. In one call, as the PR recommends:apm install con/skills/skills/code-quality-report-conventions#<commit> con/skills/skills/review-repo-code-quality#<commit> [con/skills/skills/review-org-code-quality#<commit>]- Same file, line 25: "Bump
version:here when…" now fails E011 if followed literally. Sayapm.ymland here. skills/code-quality-report-conventions/report-conventions.md:32: "anapm.lock.yamlwith acon/skillsentry" can now match several entries at different commits. It should name the entry whosevirtual_pathisskills/{skill name}. This one changes what a run does, so it is a PATCH bump of that skill.
Two questions, not requests:
- The version of the five stamping skills now lives in two files, with E011 and its test to keep them equal. APM deploys
apm.ymlbesideSKILL.md, so those skills could read it from there and the frontmatter copy and E011 could go. The cost: an extra file read at run time, and a changed stamping step in five skills. Worth it? review-repo-code-qualityandreview-org-code-qualityneedcode-quality-report-conventionsat run time. Adependencies:entry in theirapm.ymldoes resolve transitively for subdirectory packages of the same repository (run with a range against tags in a mirror). Without tags it would need a SHA that is bumped on every change, so probably not for this PR.
Not checked: the two consumer repositories named in the PR body.
This review went through two independent reviewer passes (APM packaging; Python/CI and skill authoring), and both agreed with the points above.
Generated by Claude Code
…rning - Per-skill apm.yml keeps only name and version; APM needs no more, and the copied descriptions had already drifted. - code-quality-report-conventions: subdirectory install command, bump both version copies, match the lock entry by virtual_path (0.2.1). - AGENTS.md: versions start with this PR; frontmatter copy is unquoted; move pins by editing the SHA, since apm update and semver refs land on the old bare tag. Same warning in install-apm-skills. - E011 compares values directly; drop the duplicate collection test and the single-use ignore_deployed helper. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
|
Thanks for the review. Commit bf7ab39 addresses the inline points (replies are on each thread) plus the stale text outside the diff:
On your two questions:
The root Generated by Claude Code |
Say that only individual skills are installed, and drop the repository-root install check from the Git package check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
Drop version: from the five SKILL.md frontmatters that carried it. Skills that stamp their output read the version from the apm.yml beside their SKILL.md (bot-pr-sweep's pr_gate.py, suggest-skill-fixes, the review conventions). E011 now rejects a frontmatter version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
|
Update on question 1. My earlier answer, which kept the frontmatter copy, is superseded. In 9a03178, at the PR author's request, Generated by Claude Code |
yarikoptic-gitmate
left a comment
There was a problem hiding this comment.
Re-reviewed 9a03178 (bf7ab39, 6af9790, 9a03178). The first round's points are addressed, the root apm.yml decision is settled, and moving the version into apm.yml alone removes the two-file sync and reads better than what I reviewed before. Nothing blocking; one inconsistency worth fixing before merge and a few nits, all inline or below.
Worth fixing: code-quality-report-conventions is bumped to 0.2.1 while AGENTS.md says this PR bumps nothing (inline; the collision came from my first review).
What was checked this round, by two independent reviewer passes (APM packaging; Python/CI and skill authoring):
- "APM deploys
apm.ymlbesideSKILL.md", which the stamping skills now depend on, holds. Run with apm-cli 0.31.0:- Local path and Git subdirectory installs with
--target agent-skills, and--target claude, all deployapm.ymlinto the skill's directory, and the lock lists it indeployed_files. pr_gate.skill_version()on a deployed copy returns0.6.0.check_deployedinci/check_apm.pyalready compares deployed files with the source tree, so CI guards this without a new check.
- Local path and Git subdirectory installs with
- Tests:
tox -e validate,apmpasses;ci/tests(13) andskills/bot-pr-sweep/tests(128) pass;ci/validate_skills.pyreports 0 errors for 25 skills. CI is green. - Stale text: nothing in README, AGENTS.md,
ci/,tox.ini,.githuborskills/still points at a frontmatterversion:. ci/check_apm.py:--sourceis still coherent after the root-form block went (.github/workflows/validate.ymlpasses it), and no unused code is left there.
Nits without a thread:
- AGENTS.md line 141 is 103 characters; rewrap.
- Optional:
_VERSIONinpr_gate.pyreturnsunknownforversion: "0.6.0" # comment, which E010 accepts. None of the 25 manifests has one and the failure is a visibleunknown, so leaving it is fine; ending the pattern with\s*(?:#.*)?$would cover it. - Optional:
pr_gate.pyfalls back tounknownwherereport-conventions.mdandsuggest-skill-fixessayunversioned. That predates this PR.
I resolved the first round's threads, as each is addressed.
Not checked: the two consumer repositories named in the PR body.
Generated by Claude Code
- code-quality-report-conventions back to 0.2.0: this PR bumps nothing. - Drop an unused variable in E010 and the description leftovers in its test; rewrap a long AGENTS.md line. - suggest-skill-fixes: any skill without an apm.yml is unversioned. - pr_gate.py accepts a trailing comment after the apm.yml version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
|
Thanks for the re-review. Commit b93f166 addresses the inline threads and two of the nits without a thread:
I left one optional nit for a separate change.
Generated by Claude Code |
yarikoptic-gitmate
left a comment
There was a problem hiding this comment.
Re-reviewed b93f166. Everything from the second round is addressed and nothing blocking remains. One line-length nit is inline; take it or leave it.
What was checked this round, by two independent reviewer passes (APM packaging; Python/CI):
- The commit does what it says:
code-quality-report-conventionsis back at0.2.0, so everyapm.ymlversion equals the frontmatter version onmasterand noSKILL.mdcarries aversion:. _VERSIONinpr_gate.py, run against 34 inputs beside what E010 accepts:- It matches quoted, single-quoted and bare values, a trailing comment and CRLF.
- It rejects an unterminated or mismatched quote, an indented
version:and four-part or suffixed versions. - The two can disagree only on forms nobody writes in a two-line manifest (
version : "1.2.3", a quoted key, a duplicate key), where the stamp would readunknown. No change needed.
check_apm_manifest: nothing readsversionafter E010, so the removal is right, and no other dead code is left there or in its test.- Tests:
ci/validate_skills.pyreports 0 errors for 25 skills;ci/tests(13) andskills/bot-pr-sweep/tests(128) pass. CI is green on b93f166. - Reuse:
skill_versionexists in bothci/check_apm.pyandpr_gate.py, which is right, since the gate script is bundled and standard-library only.
Not run this round: tox -e apm against a real apm-cli (it ran in CI), and the two consumer repositories named in the PR body.
I resolved the second round's threads, as each is addressed. Leaving this as a comment, not an approval; merging is for a maintainer to decide.
Generated by Claude Code
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
yarikoptic-gitmate
left a comment
There was a problem hiding this comment.
Checked 692c030: it only rewraps the long AGENTS.md line, and CI is green on it. Nothing further from this review; merging is for a maintainer to decide.
Generated by Claude Code
Resolve bot-pr-sweep's version conflict: #52 bumped it to 0.7.0 in the SKILL.md frontmatter; here the version lives only in apm.yml, so it moves there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu
|
Checked 097d4bd, the merge of The earlier review stands, and I resolved the last open thread (the AGENTS.md rewrap, applied in 692c030). Merging is for a maintainer to decide. Generated by Claude Code |
|
Leaving this to @leej3 as our APM 'point person' |
Problem
Consumers that install a skill with
git: con/skills+skills: [...](e.g. bbqs-web-app-template, nwb-benchmarks-dashboard) seecon/skills 0.1.0for every skill inapm.lock.yamlandapm deps list. That is the never-bumped rootapm.yml. apm-cli 0.31.0 never reads a skill's frontmatterversion:(primitives/parser.pyparse_skill_filetakes onlynameanddescription), so the commit SHA is the only real version a consumer has.Change
skills/<name>/apm.yml(name+version) makes that skill its own APM package and is the only place its version lives. Five skills had a frontmatter version; their manifests start from it, and every other skill starts at0.1.0. No version is bumped in this PR.version:is removed from those fiveSKILL.mdfiles. The skills that stamp their output (bot-pr-sweep'spr_gate.py,suggest-skill-fixes, thereview-*conventions) now read the version from theapm.ymlthat APM deploys besideSKILL.md.validate_skills.pyfails on a missing or invalid manifest (E010) and on any frontmatterversion:(E011).apm.ymlis removed. con/skills is a monorepo of independent skills, not a package to install as a whole.check_apm.pyinstalls and restores each skill as a subdirectory package.install-apm-skills,author-apm-skillsandcode-quality-report-conventionsare updated.apm.ymlat that commit. No tags are used.Verified (apm-cli 0.31.0)
apm install con/skills/skills/<name>#<sha>: the lock records the skill's own name and version (bot-pr-sweep 0.6.0), andapm.ymlis deployed next toSKILL.md.apm install --frozenandapm audit --ci, since they pin a SHA.tox -e validate,apm,security-static,security-depsandcheck_apm.py --sourcepass.Consumers
Nothing changes until the next pin move. Then replace
{git: con/skills, ref, skills: [...]}with one{git: con/skills, path: skills/<name>, ref: <sha>}per skill. Move pins by editing the SHA, not withapm update, which can resolve to the old bare tag0.20261015.0.Relation to #50
#50 no longer edits AGENTS.md, so the two can merge in either order. If this PR merges first, #50's
setup-chromaticrework should bumpskills/setup-chromatic/apm.ymlto0.2.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01DQrzw79etX6u2VyPivrDeu