Repository navigation
Drop the datalad pin; floor datalad at 1.8.0 - #164
Merged
Merged
Conversation
Every campaign env pinned datalad to the datalad/datalad#7904 head (2947978), because released 1.6.2 crashed in save._inject_sub_info when a `datalad run` command commits in a subdataset below a plain directory. #7904 is released now, so datalad goes back to a transitive dependency through mechababs' own floor. The floor is datalad>=1.8.0, past the >=1.6.3 the issue names: 1.6.3 carries #7904 but not 484f67be4 ("BF: support linked git worktrees, where .git is a file", first released in 1.6.4), which a superstudy kept as a git worktree needs. The pin predated that fix too. 1.8.0 is the current release. The dispatch docstring no longer names a version, so it does not drift with the floor. Closes con#146 Co-Authored-By: Claude Code 2.1.328 / Claude Opus 5.5 <noreply@anthropic.com>
asmacdo
marked this pull request as ready for review
November 19, 2026 17:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the temporary datalad pin now that datalad/datalad#7904 is released, and floor datalad at
>=1.8.0so campaigns resolve a released datalad again.Closes #146
campaign_init.py: removeDATALAD_PIN(the #7904 head sha); datalad is no longer a direct campaign dependency and comes in through mechababs.pyproject.toml:datalad>=1.6→datalad>=1.8.0. Past the>=1.6.3the issue names: 1.6.3 carries #7904 but not datalad/datalad@484f67be4 (support for linked git worktrees, where.gitis a file; first released in 1.6.4), which a superstudy kept as a git worktree needs. 1.8.0 is the current release.dispatch.py: therequire_runcmd_headdocstring no longer names a version, so it does not drift with the floor.tests/test_campaign_init.py: delete the TEMPORARY pin test.No docs mention the pin.
Verified: unit tests 418 passed;
ruff@0.16.4check + format clean; podman e2e 4 passed againstPennLINC/babs@main, and every campaign it created locked datalad 1.8.0 from PyPI.🤖 Generated with Claude Code