Skip to content

Drop the datalad pin; floor datalad at 1.8.0 - #164

Merged
asmacdo merged 1 commit into
con:mainfrom
asmacdo:146-datalad-pin
Nov 19, 2026
Merged

asmacdo merged 1 commit into
con:mainfrom
asmacdo:146-datalad-pin

Conversation

@asmacdo

@asmacdo asmacdo commented Nov 19, 2026

Copy link
Copy Markdown
Member

Drop the temporary datalad pin now that datalad/datalad#7904 is released, and floor datalad at >=1.8.0 so campaigns resolve a released datalad again.

Closes #146

  • campaign_init.py: remove DATALAD_PIN (the #7904 head sha); datalad is no longer a direct campaign dependency and comes in through mechababs.
  • pyproject.toml: datalad>=1.6 → datalad>=1.8.0. Past the >=1.6.3 the issue names: 1.6.3 carries #7904 but not datalad/datalad@484f67be4 (support for linked git worktrees, where .git is a file; first released in 1.6.4), which a superstudy kept as a git worktree needs. 1.8.0 is the current release.
  • dispatch.py: the require_runcmd_head docstring no longer names a version, so it does not drift with the floor.
  • tests/test_campaign_init.py: delete the TEMPORARY pin test.

No docs mention the pin.

Verified: unit tests 418 passed; ruff@0.16.4 check + format clean; podman e2e 4 passed against PennLINC/babs@main, and every campaign it created locked datalad 1.8.0 from PyPI.

🤖 Generated with Claude Code

Every campaign env pinned datalad to the datalad/datalad#7904 head
(2947978), because released 1.6.2 crashed in save._inject_sub_info when a
`datalad run` command commits in a subdataset below a plain directory.
#7904 is released now, so datalad goes back to a transitive dependency
through mechababs' own floor.

The floor is datalad>=1.8.0, past the >=1.6.3 the issue names: 1.6.3
carries #7904 but not 484f67be4 ("BF: support linked git worktrees, where
.git is a file", first released in 1.6.4), which a superstudy kept as a
git worktree needs. The pin predated that fix too. 1.8.0 is the current
release.

The dispatch docstring no longer names a version, so it does not drift
with the floor.

Closes con#146

Co-Authored-By: Claude Code 2.1.328 / Claude Opus 5.5 <noreply@anthropic.com>
@asmacdo
asmacdo marked this pull request as ready for review November 19, 2026 17:06
@asmacdo
asmacdo merged commit a5f54d4 into con:main Nov 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop the temporary datalad pin once a release carries datalad/datalad#7904

1 participant