Repository navigation
Dead-code sweep: empty the known-dead list and hunt the rest - #140
Merged
Merged
Conversation
…e-point clone_ref answered "what ref can this checkout be re-cloned at" for the old bootstrap path, where test-cluster stood in a dev campaign and re-pinned its code from a checkout. con#127 removed that path: test-cluster now mirrors the running install via PEP 610 metadata (campaign_init.running_mechababs_pin) and takes --mechababs/--babs URL@REF for anything else, so nothing ever needs a branch name read out of a working tree. Evidence: `git grep clone_ref` finds only the definition and its four tests; RefError is raised nowhere else. Identified on the known-dead list of the study-first sprint. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pfazng8PuPvbQNN25uzK2Y
All three belonged to the campaign-as-dataset layout: bootstrap.sh cloned the code pins and built the venv, requirements-campaign.txt was the extras it installed, and merge_config.py composed pipeline x cluster x dataset into the one babs-config.yaml that `configure` fed to babs init. Study-first replaced each of them inside the package -- campaign_init builds the environment from a generated pyproject + uv.lock (CAMPAIGN_EXTRAS is the extras list), and compose.py does the composition -- and con#127 deleted `configure`, their last caller. Evidence: `git grep` for each filename hits only the three files themselves and one pyproject.toml comment, which this commit rewrites. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pfazng8PuPvbQNN25uzK2Y
It built the out-of-campaign ../repronim-containers-shim dataset that vanilla babs needed to find images before PennLINC/babs#399 resolved the ReproNim/containers layout natively. #399 merged 2026-08-19, the native path was verified at runtime on Unity 2026-08-26 (con#62's evidence), and the study-first scaffold has used it since con#119. require_shim and SHIM_DIRNAME went with con#127; this is the last piece. Evidence: no file in the tree names the script or the shim directory. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pfazng8PuPvbQNN25uzK2Y
A hand-run script from the first shakeouts: given a dataset id it checked that no OpenNeuroDerivatives/<id>-mriqc repo existed and that the raw dataset was reachable. Nothing invokes it, it is MRIQC-only and OpenNeuro-only (the two couplings the CLAUDE.md strip just moved out of the repo), and its own docstring records the false-pass on git auth/network errors that con#10 tracks. The check it did belongs, if anywhere, in add-dataset's sniff against the cloned study, which already sees the study's existing derivatives. Evidence: `git grep preflight` hits only the file and design/openneuro-findings.md. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pfazng8PuPvbQNN25uzK2Y
The findings doc is a 2026-03 exploration of the OpenNeuroStudies layout. Its durable content -- the three-org table and the study/sourcedata/derivatives shape -- is what the repo docs and the tool now encode, and the rest is our deployment's, which lives outside the repo since con#134. The ignore lines went with the layouts they hid: processing/ (the pre-campaign output tree), repronim-containers/ (the shim clone), design/*.png (that doc's figures, of which none exist). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pfazng8PuPvbQNN25uzK2Y
select.py listed desc-mechababs_datasets.tsv, the wide ledger state.py kept and con#130 deleted, among the TSVs it is not; the statefile it should contrast with is sourcedata+derivatives.tsv. test_spine's _iterate docstring explained itself by the absence of --campaign-path, a flag con#127 removed, which tells a reader nothing now. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pfazng8PuPvbQNN25uzK2Y
It is our curated list of the OpenNeuro datasets we want processed: a fact about our deployment, not about the tool. Nothing in the package reads it, and the same reasoning that took the OpenNeuro sections out of CLAUDE.md (con#134) applies to the data behind them. It lives with our deployment notes now; this repo's history keeps its past. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pfazng8PuPvbQNN25uzK2Y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tldr:
bootstrap.sh,requirements-campaign.txt,merge_config.py,tmp-repronim-container-shim.sh,preflight.py,design/openneuro-findings.md,priority-openneuro-datasets.csv,validate.clone_ref(+RefError+ its tests), three stale.gitignorelines.campaign.apps_dir(vulture flags it, but the unit suite and both e2e scenarios use it as the one definition of the path).clone_reftests), ruff both steps clean.What each file was, and what replaced it
bootstrap.sh+requirements-campaign.txt: the campaign-as-dataset installer and its extras.campaign initbuilds the environment from a generatedpyproject.toml+uv.lock;campaign_init.CAMPAIGN_EXTRASis the extras list.merge_config.py: composed pipeline × cluster × dataset into the onebabs-config.yamlforconfigure.compose.pydoes this in-package;configureitself went with Test cluster repoint #127.tmp-repronim-container-shim.sh: built the sibling shim dataset vanilla babs needed before Resolve container image paths from datalad PennLINC/babs#399. Native resolution is verified on Unity (Remove the ../repronim-containers-shim once babs#383 lands (+ add simbids upstream to ReproNim/containers) #62's evidence);require_shimwent with Test cluster repoint #127.preflight.py: a hand-run, MRIQC-only, OpenNeuro-only pre-check from the first shakeouts. Nothing invokes it. preflight.py is pipeline-blind and false-passes on git auth/network errors #10 is closed; nothing in the tool replaces it.design/openneuro-findings.md: a 2026-03 exploration of the OpenNeuroStudies layout. What is durable in it is what the docs and the tool now encode; the deployment-specific rest left the repo with Claude md strip #134.priority-openneuro-datasets.csv: our curated list of OpenNeuro datasets to process. A fact about our deployment, not the tool, by the same reasoning as Claude md strip #134; nothing in the package reads it. It lives with our deployment notes now; this repo's history keeps its past.validate.clone_ref: read a re-clonable ref out of a checkout for the old re-pin path.test-clustermirrors the running install via PEP 610 metadata since Test cluster repoint #127.How the hunt was done
vulture --min-confidence 0over the package (e2e excluded) reports two unused functions:clone_refandapps_dir. The second is live in tests. A grep across package, tests, docs, examples and workflows for the names of every module and flag the sprint deleted (guard.py,construct.py,state.py,datalad_save_scope,configure,bootstrap,--campaign-path,derivative-attempts,desc-mechababs_datasets,run_on_cluster,--workdir, the shim,--derivative) found two docstrings still naming them, fixed in the last commit.🤖 Generated with Claude Code
https://claude.ai/code/session_01Pfazng8PuPvbQNN25uzK2Y