feat: run lightning at cpu-8 (8 vCPU / 16 GiB) in dax benchmark#199
Open
rusenask wants to merge 1 commit into
Open
feat: run lightning at cpu-8 (8 vCPU / 16 GiB) in dax benchmark#199rusenask wants to merge 1 commit into
rusenask wants to merge 1 commit into
Conversation
Contributor License AgreementAll contributors are covered by a CLA. |
Lightning was in the dax matrix but had no resource sizing, so it ran on the SDK default cpu-1 (1 vCPU) while other providers standardized to 8 vCPU / 16 GiB, making results incomparable. Lightning's @computesdk/lightning wrapper sets instanceType from the provider factory config and overrides any instanceType passed to sandbox.create(), so it can't be sized through DAX_RESOURCE_OPTIONS like most providers. Instead, read LIGHTNING_INSTANCE_TYPE in createCompute (default cpu-1, the SDK default) and set it to cpu-8 in the dax workflow, mirroring how northflank reads its plan from env with a fallback. This scopes the 8 vCPU sizing to the dax benchmark and leaves other modes (e.g. TTI) on the default. Verified against lightning.ai: sandbox reports 8 logical CPUs, all 7 dax phases complete.
rusenask
force-pushed
the
dax-lightning-cpu-8
branch
from
July 23, 2026 18:11
33d0c60 to
e7b2015
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sizes the lightning provider to 8 vCPU / 16 GiB (
cpu-8) in the dax benchmark, matching the standardized resource profile introduced in #196.Why
Lightning was already in the dax matrix but had no resource sizing, so it ran on the SDK default
cpu-1(1 vCPU) while every other provider used 8 vCPU / 16 GiB — making its results incomparable (the same issue #196 fixed for the rest of the matrix).How
Lightning can't be sized through
DAX_RESOURCE_OPTIONSlike most providers. The@computesdk/lightningwrapper appliesinstanceTypefrom the provider factory config and overrides anyinstanceTypepassed tosandbox.create():So sizing has to happen at
createComputetime. This PR:LIGHTNING_INSTANCE_TYPEincreateCompute(defaultcpu-1, the SDK default), mirroring hownorthflankreads its deployment plan from env with a fallback.LIGHTNING_INSTANCE_TYPE: cpu-8in the dax workflow env, scoping the 8 vCPU sizing to the dax benchmark and leaving other modes (e.g. TTI) on the default.dax.ts(next to the existing E2B note) andenv.example.Verification
Ran the dax benchmark against lightning.ai with
cpu-8:The sandbox reports 8 logical CPUs, confirming
cpu-8took effect, and all 7 dax phases complete.🤖 Generated with Claude Code