Skip to content

fix: normalise email to lowercase and prevent duplicate accounts #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0x5t4l1n wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −3
Open

fix: normalise email to lowercase and prevent duplicate accounts #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions hknweb/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,23 @@ class SignupForm(UserCreationForm):

def clean_email(self):
email = self.cleaned_data.get("email")
# Normalise to lowercase so User@Berkeley.EDU and user@berkeley.edu
# are treated as the same address throughout the system.
if email:
email = email.lower()
if (email is None) or not email.endswith(
"berkeley.edu"
): # lgtm [py/incomplete-url-substring-sanitization]
raise forms.ValidationError(
"Please a berkeley.edu email to register!", code="invalid"
"Please use a berkeley.edu email to register!", code="invalid"
)
else:
return email
# Reject duplicate addresses (case-insensitive) to prevent phantom accounts.
if User.objects.filter(email__iexact=email).exists():
raise forms.ValidationError(
"An account with this email address already exists.",
code="duplicate",
)
return email

class Meta:
model = User
Expand Down