Skip to content

Fix emscripten library linker warning - #1168

Open
mcbarton wants to merge 4 commits into
compiler-research:mainfrom
mcbarton:Fix-Emscripten-library-linker-error
Open

mcbarton wants to merge 4 commits into
compiler-research:mainfrom
mcbarton:Fix-Emscripten-library-linker-error

Conversation

@mcbarton

@mcbarton mcbarton commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

This change will fix the linker warning we get on main when we try and link the Emscripten static library to the test executable

wasm-ld: warning: function signature mismatch: _ZN5clang17ExternalASTSource19getSourceDescriptorEj
  >>> defined as () -> void in /home/runner/work/CppInterOp/CppInterOp/install/build/lib/libclangAST.a(ExternalASTSource.cpp.o)
  >>> defined as (i32, i32, i32) -> void in unittests/CppInterOp/CppInterOpTests.wasm.lto.o
  wasm-ld: warning: function signature mismatch: _ZN5clang17ExternalASTSource19getSourceDescriptorEj
  >>> defined as () -> void in /home/runner/work/CppInterOp/CppInterOp/install/build/lib/libclangAST.a(ExternalASTSource.cpp.o)

@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.80%. Comparing base (ede86c2) to head (be5123a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   88.80%   88.80%           
=======================================
  Files          24       24           
  Lines        6978     6978           
=======================================
  Hits         6197     6197           
  Misses        781      781           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton mcbarton changed the title Fix emscripten library linker error Fix emscripten library linker warning Nov 1, 2026
@mcbarton
mcbarton requested a review from vgvassilev November 2, 2026 07:03
@mcbarton
mcbarton marked this pull request as ready for review November 2, 2026 07:03
@mcbarton
mcbarton requested a review from aaronj0 November 2, 2026 09:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant