Repository navigation
Conversation
compiler-research#830 left CPPINTEROP_ENABLE_CLAD rejected under emscripten. Cross-building clad needs its configure step driven through emcmake, and clad v2.5 refuses to cross-compile without a host clad-tblgen, so the plugin gains CLAD_TABLEGEN_EXE, mirroring CPPINTEROP_TABLEGEN_EXE. Tested on the llvm-wasm-23 cell with emsdk 6.0.8, clad on and off. The option stays off by default and no CI row enables it: clad v2.5 compiles its repl error-recovery guard out on clang >= 22, so a parse error in a clad-enabled interpreter replays a discarded ast until the stack overflows.
The emscripten shared-library rows build a host clad-tblgen next to cppinterop-tblgen, reading the clad version from the pin in plugins/clad/CMakeLists.txt, and configure with CPPINTEROP_ENABLE_CLAD=ON. The static rows only run on schedule and build at one core, so they stay off.
aaronj0
requested review from
mcbarton and
vgvassilev
and removed request for
vgvassilev
November 1, 2026 11:22
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 24 24
Lines 6978 6978
=======================================
Hits 6197 6197
Misses 781 781 🚀 New features to boost your workflow:
|
Collaborator
|
I had a cursory look at this PR. The things which stood out are
|
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#830 left CPPINTEROP_ENABLE_CLAD rejected under emscripten. Cross-building clad needs its configure step driven through emcmake, and clad v2.5 refuses to cross-compile without a host clad-tblgen, so the plugin gains CLAD_TABLEGEN_EXE, mirroring CPPINTEROP_TABLEGEN_EXE.
Tested on the llvm-wasm-23 cell with emsdk 6.0.8, clad on and off. The option stays off by default and no CI row enables it: clad v2.5 compiles its repl error-recovery guard out on clang >= 22, so a parse error in a clad-enabled interpreter replays a discarded ast until the stack overflows.