Add vm_extract_image, which two VM scripts already call - #40
Merged
Merged
Conversation
haos-vm and opnsense-vm were switched over to it, but it was never added here, so both died with "vm_extract_image: command not found" right after creating the VM shell. Takes the format from the file name and leaves the archive in place, so a cached download survives. Without a target the image lands in the tmp dir with the suffix removed, and VM_IMAGE_FILE names the result either way.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/vm-extract-image \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/ct/debian.sh)"Swap This PR touches Run a script from a fork as wellcurl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/vm-extract-image/tools/run.sh |
bash -s -- https://raw.githubusercontent.com/YOU/ProxmoxVED/your-branch ct/debian.sh \
https://raw.githubusercontent.com/community-scripts/core/fix/vm-extract-imageNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
haos-vmandopnsense-vmwere switched over tovm_extract_image, but it was never added here, so both die withvm_extract_image: command not foundright after creating the VM shell.Takes the format from the file name and leaves the archive in place, so a cached download survives. Without a target the image lands in the tmp dir with the suffix removed;
VM_IMAGE_FILEnames the result either way, which is what both call sites read.🔗 Related Issue
Fixes # Discord
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.