Skip to content

VM's: show the selected CPU model instead of doubling it - #37

Merged
MickLesk merged 1 commit into
mainfrom
fix/cpu-model-label
Sep 12, 2026
Merged

VM's: show the selected CPU model instead of doubling it#37
MickLesk merged 1 commit into
mainfrom
fix/cpu-model-label

Conversation

@MickLesk

@MickLesk MickLesk commented Sep 12, 2026

Copy link
Copy Markdown
Member

✍️ Description

${CPU_TYPE:+...}${CPU_TYPE:-KVM64} expands both arms when CPU_TYPE is set, so picking Host printed CPU Model: host -cpu host. The summary block had the other half: it matched only *host*, so x86-64-v3 showed as KVM64. One label helper now serves both.

🔗 Related Issue

Fixes Own finding due testing

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🤖 AI Assistance (X in brackets)

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

${CPU_TYPE:+...}${CPU_TYPE:-KVM64} expands both arms when CPU_TYPE is
set, so picking Host printed "host -cpu host". The summary block had the
other half of the problem: it matched only *host*, so x86-64-v3 showed
as KVM64. One label helper now serves both.
@github-actions

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/cpu-model-label \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVED/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

This PR touches pve/, so it needs a Proxmox VE host.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/cpu-model-label/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/ProxmoxVED/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/cpu-model-label

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk MickLesk changed the title Show the selected CPU model instead of doubling it VM's: show the selected CPU model instead of doubling it Sep 12, 2026
@MickLesk
MickLesk merged commit 49ccc2c into main Sep 12, 2026
4 checks passed
@github-actions
github-actions Bot deleted the fix/cpu-model-label branch September 13, 2026 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant