Skip to content

changedetection: remove msttcorefonts to fix install hang - #16319

Merged
michelroegl-brunner merged 4 commits into
community-scripts:mainfrom
austinpilz:fix-changedetection-msttcorefonts-eula
Aug 7, 2026
Merged

changedetection: remove msttcorefonts to fix install hang#16319
michelroegl-brunner merged 4 commits into
community-scripts:mainfrom
austinpilz:fix-changedetection-msttcorefonts-eula

Conversation

@austinpilz

Copy link
Copy Markdown
Contributor

✍️ Description

Remove msttcorefonts from the changedetection font package list to fix an indefinite install hang on headless LXC environments.

msttcorefonts requires downloading fonts from SourceForge at install time, which frequently stalls or times out in a headless container with no interactive TTY. Pre-seeding the debconf EULA bypasses the interactive prompt but not the SourceForge download. fonts-liberation (already in the list) provides metric-compatible Arial/Times/Courier New replacements and is sufficient for Playwright/Browserless rendering.

AI assistance: Claude Sonnet 4.6, medium reasoning level.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any scripts in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Scripts were written without AI assistance.
  • AI was used – I confirm the scripts were built using AGENTS.md and .github/agents/pve-script-creator.agent.md as guidance, and the output has been reviewed and corrected to match those guidelines.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to script metadata (PocketBase/website data).
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

root and others added 4 commits August 6, 2026 17:49
apt-get install msttcorefonts triggers a debconf EULA prompt with no
tty to answer it, so the "Installing Font Packages" step can hang
indefinitely (reported stuck 15+ min). apache-tika-install.sh and
onlyoffice-install.sh already work around this by preseeding the
answer with debconf-set-selections before the install; apply the same
fix here.
build.func fetches the install script from the upstream hardcoded URL,
so simply running ct/changedetection.sh from our fork uses the unfixed
upstream install script. Override the curl command after sourcing
build.func to intercept that specific URL and redirect it to our fork's
fix-changedetection-msttcorefonts-eula branch, which has the EULA
preseed for msttcorefonts.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
msttcorefonts downloads fonts from SourceForge at install time;
debconf EULA pre-selection only bypasses the interactive prompt,
not the network download. fonts-liberation is already in the list
and provides metric-compatible Arial/Times/Courier replacements.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the interim curl-override workaround from ct/changedetection.sh
that was routing installs to our fork. The actual fix (removing msttcorefonts
from install/changedetection-install.sh) is already in place; the redirect
is no longer needed and shouldn't be in the upstream PR.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@austinpilz
austinpilz requested a review from a team as a code owner August 6, 2026 23:00
@github-actions github-actions Bot added bugfix update script A change that updates a script labels Aug 6, 2026
@austinpilz

Copy link
Copy Markdown
Contributor Author

Verified functionality (with the removed dependency) WAD via fresh install. Tested the ChangeDetector installation, web page tracking, properly received notifications, etc.

@michelroegl-brunner
michelroegl-brunner merged commit 156f5ae into community-scripts:main Aug 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants