fix(dispatcharr): add comskip installation and build dependencies - #16224
fix(dispatcharr): add comskip installation and build dependencies#16224eXistC wants to merge 3 commits into
Conversation
github-actions
Bot
added
bugfix
feature
update script
|
Don't use |
…ng release tarball
d60b9c5 to
9768e7a
Compare
Thanks for the feedback! I just pushed an update per your recommendations |
| msg_info "Compiling Comskip" | ||
| if [[ ! -d "/opt/Comskip" ]]; then | ||
| mkdir -p /opt/Comskip | ||
| wget -qO- https://github.com/erikkaashoek/Comskip/archive/refs/heads/master.tar.gz | tar -xz -C /opt/Comskip --strip-components=1 |
There was a problem hiding this comment.
is the tar command this verbose upon running (eg does it need $STD?
There was a problem hiding this comment.
ah, i thought it was fine since i uses the -xz flag makes it silent. but now that you mention it, i realized definitely still needs $STD to handle exceptions properly. Thanks for pointing that out! I'll push a fix.
There was a problem hiding this comment.
Wait, actually, when @tremor021 mentioned using a release tarball earlier, I completely missed that there's actually a built-in helper function fetch_and_deploy_from_url exactly for this. I'll get that swapped over!
eXistC
left a comment
eXistC
left a comment
There was a problem hiding this comment.
Pushed a new commit to use the native fetch_and_deploy_from_url helper function!
| msg_info "Compiling Comskip" | ||
| if [[ ! -d "/opt/Comskip" ]]; then | ||
| mkdir -p /opt/Comskip | ||
| wget -qO- https://github.com/erikkaashoek/Comskip/archive/refs/heads/master.tar.gz | tar -xz -C /opt/Comskip --strip-components=1 |
There was a problem hiding this comment.
ah, i thought it was fine since i uses the -xz flag makes it silent. but now that you mention it, i realized definitely still needs $STD to handle exceptions properly. Thanks for pointing that out! I'll push a fix.
| msg_info "Compiling Comskip" | ||
| if [[ ! -d "/opt/Comskip" ]]; then | ||
| mkdir -p /opt/Comskip | ||
| wget -qO- https://github.com/erikkaashoek/Comskip/archive/refs/heads/master.tar.gz | tar -xz -C /opt/Comskip --strip-components=1 |
There was a problem hiding this comment.
Wait, actually, when @tremor021 mentioned using a release tarball earlier, I completely missed that there's actually a built-in helper function fetch_and_deploy_from_url exactly for this. I'll get that swapped over!
3 participants
✍️ Description
Adds the installation and compilation of Comskip to the Dispatcharr LXC script, enabling automated video commercial detection for DVR recordings.
Context
Dispatcharr already expose the UI and settings for Comskip commercial detection, but the necessary binary and system build dependencies were missing from the default LXC installation. Because of this oversight, the
dispatcharr-celeryworker could not execute the commercial detection jobs dispatched by the frontend. This PR fixes the incomplete installation.Changes
build-essential,autoconf,libtool,libargtable2-dev,libavformat-dev,libsdl2-dev, andlibswscale-dev) to the installation script.comskipbinary is globally accessible to the Celery workers.$STDvariable to maintain compliant, non-verbose terminal output.🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.