feat: Adding settings, utils, write to S3, and writer close#67
feat: Adding settings, utils, write to S3, and writer close#67
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 95.78% 97.12% +1.34%
==========================================
Files 7 9 +2
Lines 877 939 +62
==========================================
+ Hits 840 912 +72
+ Misses 37 27 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Given that the test coverage check fails on this one, what about adjusting the coverage check to a fixed value instead of the last coverage value? |
|
While the coverage check failed, I don't think it will cause a problem in the next CI run? It's just a slightly easier hurdle next time. |
I added additional unit tests which should increase the coverage above the threshold. However, codecov seemed to stopped working after moving the repo to the CC org. I already requested access to the org. I guess you just need to approved codecov again @wumpus. |
|
The Codecov checks pass now. |
damian0815
left a comment
There was a problem hiding this comment.
'request changes' I think they only blocker issue is the boto3 require
|
Thanks for the feedback. I changed the PR accordingly. See #68 for the context manager issue. |
|
I would put the s3 support in the install target cdx_toolkit[s3] and also make an [all], similar to what warcio is now. As an external tool, it's worth having a small install. And there may be situations where the full install on an older python version will fail because of s3 dependencies. |
|
@wumpus I agree. The dependencies have been changed accordingly. The CI also run tests with both setups, "all" and the minimal installation. |
This PR integrates a couple of general changes from the EOT PR (#54):
settings.pyutils.pywriter.close()statement is added to CLI and example.