fix esm output - #1
Closed
flobacher wants to merge 4 commits into
Closed
Conversation
Contributor
|
Thank you @flobacher ! Merged via #2 |
Contributor
Author
|
Happy to contribute 🙌 |
Contributor
|
@flobacher New versions released for all packages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simmilar to the git-adapter-github pr, this adds the extensions to relative imports.
As it feels weird and breaks direct execution of ts files, I opted to the ts extension, that tsc will change to js upon compilation due to the
rewriteRelativeImportExtensions: truecompiler setting.To make the nodejs runtime aware to treat the files from the esm output dir as esm, the most minimalistic
package.jsonwithtype:moduleis added upon build.One final optimisation is the exclusion of tsbuildinfo files (ts incremental build cache afaik) from the published npm package. If you approve to this please add this to the git-adapter-github pr as well. Thank you very much for your awesome work on commitspark 🎉
The one usecase I found the bug with (creating migrations via the payload-cms cli that runs esm natively in nodejs without further compilation steps) works with the updated esm version. The commonjs version also still works..