fix: esm-compatibility - #9
Closed
flobacher wants to merge 3 commits into
Closed
Conversation
Contributor
|
Hi @flobacher, thank you! How much I love the simplicity of the TS/JS build ecosystem... I assume importing In any case, I did a few additional changes in branch https://github.com/commitspark/git-adapter-github/tree/fix/esm-build that you could review. Thanks. |
Contributor
|
Merged via #10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using commitspark in an esm environment where nodejs loads the files without any further processing from
dist/esmthis was broken due totype: moduleThis PR should fix that by adding the extensions to the imports.
The ts setting
rewriteRelativeImportExtensions: trueconverts them correctly to js in the output files.