implement MSC4440 biography support#893
Open
RoootTheFox wants to merge 6 commits intocommetchat:mainfrom
Open
Conversation
Co-authored-by: Rye <git@itsrye.dev>
Signed-off-by: rooot <hey@rooot.gay>
Signed-off-by: rooot <hey@rooot.gay>
Signed-off-by: rooot <hey@rooot.gay>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements MSC4440 as alternative and standardised format to Commets own biography field.
(most of the code was written by @dozro, but i took over and fixed it up)
Currently, this will still set Commets own key in addition to MSC4440 for backwards compatibility with older versions of Commet.
However, if an MSC4440 field is set, it will prefer rendering that one over the Commet one (which shouldn't break any "legacy" biographies, as they're only set on the Commet field and the new one won't exist)
Ideally, after a few versions/weeks/months of this being merged and released, no longer setting the Commet biography and removing its profile key seems ideal, and after some time later, fully removing it. Though that's out of scope for this PR :3