Repository navigation
test: arrow_import records its three date-range arms as skipped without pyarrow (#1398) - #1399
Merged
Merged
Conversation
…ut pyarrow (#1398) e88af2b (#1363) added three pyarrow-dependent checks to arrow_import's pyarrow branch but not to the no-pyarrow branch's check_skip list. Without pyarrow they vanished instead of recording a skip, so capability_sweep classed the suite as declining, which the sweep reserves for suites that call pgc_skip pyarrow, and the nightly went red. The three names join the list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VvWuX1zUwk6Y513waRd4N
OffgridwithJD
approved these changes
Oct 14, 2026
OffgridwithJD
left a comment
OffgridwithJD
left a comment
Collaborator
There was a problem hiding this comment.
Approved at 3501c94, with full CI green. Thanks for cleaning up after my #1363.
- The change is exactly the three names in the no-pyarrow
check_skiplist (git diff $(merge-base) pr:arrow_import.sh | 3 +++). - Merged onto today's main (after #1395), it auto-merges, keeping #1395's SQLSTATE arms and adding only the three lines.
- Reproduced,
capability_sweepon PG18: main gives 14 + 1 failed,-- decline mismatch: arrow_import.sh/… pgc_skip pyarrow: got [1] want [0]. Main with this merged gives 15/15.
🤖 Generated with Claude Code
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1398. Main's nightly is red on
capability name-set sweep.Cause
e88af2b (#1363) added three checks to
arrow_import.sh's pyarrow branch:It didn't add them to the no-pyarrow branch's
check_skiplist. With pyarrow shimmed out, the three disappear instead of recording a skip.capability_sweepthen classes arrow_import as declining, which it reserves for suites that callpgc_skip pyarrow, and arrow_import doesn't. I reviewed and merged #1363 without catching this.Fix
The three names join the
check_skiplist. With pyarrow present, nothing changes.Evidence (
capability_sweep, PG18)-- decline mismatch: arrow_import.sh,the suites that decline are exactly the suites that call pgc_skip pyarrow: got [1] want [0](the nightly's failure); preserved=4, declined=26Bookkeeping
No ledger change: that sweep check is already dated (2026-10-12), and no check name changes. #1395 rewrites parts of
arrow_import.sh, but not this list, so any conflict is in context lines only.🤖 Generated with Claude Code
https://claude.ai/code/session_019VvWuX1zUwk6Y513waRd4N