Repository navigation
test: create_rollup's last refusals and rebase_rollup's, in both twins (#1341) - #1359
Merged
jdatcmd merged 2 commits intoOct 14, 2026
Merged
Conversation
jdatcmd
approved these changes
Oct 14, 2026
jdatcmd
left a comment
Collaborator
There was a problem hiding this comment.
Approving the content at 8ed2b65. On PG17 I reproduced the timestamptz claim with create_rollup's check disabled:
- main: rollup passes 72/72.
- this head: "a ts_column that is not timestamptz is refused: got [ok] want [22023]" and "and no refused rollup left a table behind: got [1] want [0]". That second arm gaining this mutation is right, as you say.
Before merge: CI hadn't reported on this head when I looked, and main has moved to 1933577 (2343 / 1796). With your four dated rows I expect 2347 / 1796. It also overlaps #1357 in rollup.sh and test_rollup.py. I suggest #1357 lands first, then this one rebases onto it.
commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
commandprompt#1341) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
@jdatcmd, rebased onto 8c61dff (#1357 merged). The new head is 7af80c9, replacing 8ed2b65. Ledger: 2353 / 1798 (2349 + 4 dated).
I'll ping on green CI. |
OffgridwithJD
force-pushed
the
test/1341-rollup-refusals
branch
from
October 14, 2026 01:58
8ed2b65 to
7af80c9
Compare
Collaborator
Author
jdatcmd
approved these changes
Oct 14, 2026
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1341: create_rollup's remaining refusals and rebase_rollup's, from the medium and low items. Every arm is in both twins, next to the existing refusal arms. Each is red when the check it names is deleted from
pgcolumnar--1.0-alpha5.sql, and main survives each deletion.IF NOT FOUNDremovedThe timestamp case is the one that matters most. A
timestamp(no zone) source column would be bucketed in whatever zone the refresh happens to run in, so the refusal is the documented behaviour. With the check gone, the create succeeds, which is why the existing "no table left behind" arm also gains this mutation in the ledger.Evidence
Overlap with #1357: both touch rollup.sh and test_rollup.py in different places, and both move the budget, so whichever lands second restates.
🤖 Generated with Claude Code