Repository navigation
docs: alpha5 release notes cover the seven time-series features - #1333
Conversation
The notes were drafted on 2026-10-12, before the owner made the seven time-series features (#1290-#1296) the gate for alpha5, and named encoding as the only theme. They now have a Time series section, two highlights, the new setting and the changed default, three user-visible fixes (#1327, #1323, the unlocked partition open), two known issues, and the catalogs and functions the upgrade adds. Each statement is taken from the CHANGELOG entry or the reference section of the feature it describes. docs_style 58/58. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OffgridwithJD
left a comment
There was a problem hiding this comment.
Review at 7c30706. I checked the release notes against the source rather than against the CHANGELOG.
Checked against the source, all correct
- Settings: I diffed the
Define*Variablecalls betweenv1.0-alpha4and main. Exactly five are new (autovacuum_expire,enable_post_codec_encoding_choice,index_min_blocks,rollup_pause,tier_fault_after), and none was removed.rollup_pauseandtier_fault_afterarePGC_SUSET, so "only a superuser can set them" is right.autovacuum_expireisPGC_SIGHUP, so "takes effect on reload" is right.
- Catalogs: I diffed the
CREATE TABLEs in the two install scripts. Exactly four are new:column_extent,retired_group,rollupandrollup_group. - Functions: I diffed the
CREATE FUNCTIONs. The seven named in "What the upgrade changes", plusrollup_source_groupsandrollup_source_retiredas "two internal helpers". Nothing else. - What I built:
- The tiering paragraph matches #1317: ACCESS EXCLUSIVE from the detach to commit, every lock bounded by
lock_wait, and the foreign partition keeping its name, bounds, grants and comment. - The collation fix and the
COMMIT PREPAREDcrash read right. - The known issue on the cap is accurate now that #1330 gates on a bound.
- The tiering paragraph matches #1317: ACCESS EXCLUSIVE from the detach to commit, every lock bounded by
Three changes
-
#1331 isn't in it yet. The highlight says "pg_partman and two new functions manage time partitions", but the "Time partitions" section and the upgrade list name only
partition_create_ahead. Once #1331 merges, these need:partition_drop_planin that section;partition_drop_planand its helperpartition_drop_candidatesin "What the upgrade changes", which makes it two helpers for rollups and one for partitions.
A sentence for the section, if it helps:
pgcolumnar.partition_drop_plan(parent, cutoff)returns the statements that drop every partition older than the cutoff: a concurrent detach and a drop each, run with\gexec. It never takes an exclusive lock on the parent, and a drop refuses while its partition is still attached. -
The rollup known issue misses the refusal #1328's review added. A refresh also refuses (
0A000) when rows were deleted from a row group thatexpirethen retired before the refresh. The deleted rows are gone, so their buckets can't be recomputed. Suggested:A refresh also refuses when rows were deleted from a row group that
expireretired before the refresh. -
#1310, one word stronger than the code. "When nothing can qualify, it answers from the column's extent" is true only when a complete extent shows it. A table whose extent isn't complete yet still reads every group's zone map. Suggested:
When the column's extent shows that nothing can qualify, it answers in one index lookup instead of reading every row group's zone map.
docs_style I took from your run. I haven't rerun it.
|
@OffgridwithJD, thank you for checking against the source. All three are in at 6a5a958:
This PR merges after #1331, so the notes never name a function main doesn't have. #1331's merge is waiting on CI. |
|
@OffgridwithJD, the release notes at 6a5a958 carry your three corrections, and CI is 15/15. With #1331 merged and #1334 about to merge, this is the last content PR before the tag-day PR (release date and CHANGELOG rename). Please review when you can. Also, for the tag: at the owner's request I rebuilt my container's PostgreSQL 15–19 from fresh release tarballs, with contrib, hll, tdigest and pg_partman on every major. A full matrix and pytest run on all five majors is under way at 614eb02. I'll post the results here before asking the owner for the tag. |
OffgridwithJD
left a comment
There was a problem hiding this comment.
Approved at 6a5a958.
- All three corrections are in.
partition_drop_planis in both the Time partitions section and the upgrade list.- Diffing the
CREATE FUNCTIONs betweenv1.0-alpha4and main gives exactly the eight named plus three helpers:rollup_source_groups,rollup_source_retiredandpartition_drop_candidates. - The settings and catalog claims are unchanged from my earlier check, and
partition_drop_planadded neither.
|
Merging: approved by @OffgridwithJD at 6a5a958, and CI is green on that head. |
The alpha5 release notes before the tag. They were drafted on 2026-10-12, before the owner made the seven time-series features the gate for alpha5, and named encoding as the only theme. All seven are now merged (#1292 closed with #1330), so the notes describe them.
@OffgridwithJD, please check the facts against what you built, above all tiering, partitions and the daemon expire.
What changes in
RELEASE_NOTES_1.0-alpha5.mdpgcolumnar.autovacuum_expireis added, andpgcolumnar.enable_group_vectorizationchanges fromofftoon. The two developer settings,rollup_pauseandtier_fault_after, get one sentence. I diffed the setting definitions incolumnar_tableam.cbetweenv1.0-alpha4and main: those five are the only new ones, and none was removed.COMMIT PREPAREDcrash (COMMIT PREPARED in the preparing session crashes the backend after a pgcolumnar write #1323), and the unlocked partition open on a non-recursingALTER TABLE.column_extentstarting empty for existing tables.How the statements were checked
float8average in a rollup can differ in the last digits;max(ts)/min(ts)read no data only for groups without deletes;lock_waitbounds every locktier_partitiontakes;docs_style58/58.Also done for the tag, not in this PR
v1.0-alpha4:extension_upgrade.sh v1.0-alpha4passes on PG15–19 at main b55cb23. The upgraded catalog is byte-identical to a fresh alpha5 install (211 objects) on each major.Still to do on tag day
The release date (
TODO(release)), renaming the CHANGELOG's[Unreleased]section, and the tag.🤖 Generated with Claude Code