feat: [$500 Bounty] Refactor panda to use source + header file structure#2389
Open
Kasionchen wants to merge 2 commits intocommaai:masterfrom
Open
feat: [$500 Bounty] Refactor panda to use source + header file structure#2389Kasionchen wants to merge 2 commits intocommaai:masterfrom
Kasionchen wants to merge 2 commits intocommaai:masterfrom
Conversation
The PR commaai#2389 refactored driver modules from header-only to .c+.h structure. New .c files in board/drivers/ were not added to the SConscript build system, causing undefined reference errors during linking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the panda firmware to use separate source (.c) and header (.h) files instead of having all implementation in header files.
Changes Made
board/drivers/led.h->led.c+led.hboard/drivers/pwm.h->pwm.c+pwm.hboard/drivers/bootkick.h->bootkick.c+bootkick.hboard/drivers/fan.h->fan.c+fan.hboard/drivers/clock_source.h->clock_source.c+clock_source.hboard/drivers/registers.h->registers.c+registers.hboard/drivers/simple_watchdog.h->simple_watchdog.c+simple_watchdog.hBenefits
Bounty: This PR addresses issue #2171 which has a $500 bounty for a clean refactor.
Co-Authored-By: Kasionchen kasion.chen@gmail.com