fix: Layout shift issue when accordion is opened#894
Open
curlyfriesplease wants to merge 3 commits into
Open
Conversation
AndyEPhipps
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
Fixes a bug where, when there's a lot of text in an accordion, the layout of the text shifts during the opening animation. See the video in the attached Jira ticket.
The cause was some old CSS that is now useless, as well as being problematic.
When closed, at M breakpoint and above there is a 'lg' (3rem) lower padding on the text (even though we can't yet see the text!)
But when opened, this is then changed to 'l' (2rem). It makes this reduction at the same time as the opening animation, which results in the text visibly shifting.
Removing this CSS as it's redundant.
Also, amends an example to mimic our real world implementation where the problem was seen: it's fixed at the same width it is eventually implemented in, and has the same problematic text block currently in use on the prod site.
Why is this required?
Bugfix
link to Jira ticket:
ENG-5196
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...