fix: Monthly 'other amount' text fix for Donate Banner#893
Merged
Conversation
…AmountText and monthlyChooseAmountText
AndyEPhipps
reviewed
Jun 10, 2026
| cartID: PropTypes.string.isRequired, | ||
| donateLink: PropTypes.string.isRequired, | ||
| otherAmountText: PropTypes.string.isRequired, | ||
| monthlyOtherAmountText: PropTypes.string, |
Contributor
There was a problem hiding this comment.
This doesn't seem to get used, as the final copy is switched within DonateBanner via ahandleOtherAmountText call based on the current givingType, and the single output is passed to the Form via otherAmountText
AndyEPhipps
approved these changes
Jun 10, 2026
|
🎉 This PR is included in version 8.73.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What is it doing?
It was found that the label above the amount input field was never fully wired up. As part of the investigation it was found that we also have some redundant props, a hangover from the previous iteration of the Donate widget. This PR:
otherAmountTextormonthlyOtherAmountTextprops to label the fieldchooseAmountTextandmonthlyChooseAmountText. These used to sit above the moneybuy buttons, and we don't have that text anymore.Once this package is available I'll do the CRcom PR to finish by removing the relevant fields from the CMS.
Why is this required?
Bugfix & tidyup
link to Jira ticket:
ENG-5197
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...