-
Notifications
You must be signed in to change notification settings - Fork 0
feat: rebuild component-library using Vite #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
9183e8a
a4293f7
9d88de2
a673e14
7ca323b
ce1cb08
7ccc85d
9831cb2
45b091d
21e4494
070131c
e05d40c
282edf6
365fa40
c686869
d60e648
6f98b16
ab48fea
e4fd083
c70a346
1a6f469
066461d
b65f966
e6b086d
0b209ea
baed1c2
f4b012a
ec41f98
efc74e2
17623fe
8e06ce2
14a30bd
0049611
c6b020c
8f2487a
aa56be0
2f6d8e7
1857271
f85edae
289d9f0
2e93757
90c27c3
cad8c35
4453f62
6a276a0
e501647
59a07a1
8f9b332
6458e5f
de3401e
cea748d
29ccd9c
5e070fe
0084862
734faf9
53a1b97
b4c99ea
158cd6f
090084e
c47679c
ce3972b
45294d4
a71e792
90c02f3
9127159
56540c5
c741554
f386ed7
1b09b1e
3e6c5a2
0c5f5c2
629241f
3121a3a
f52efe6
771a3b6
4c72341
91f131d
93de615
3880a8e
f345b57
7ecebad
a9809ad
136a677
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| v16.20.0 | ||
| v18.20.0 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,22 @@ | ||
| Comic Relief React Component Library | ||
|
|
||
| Comic Relief Components Library | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's stick with component (singular) to match the package name |
||
| -------------- | ||
|
|
||
| [](https://github.com/comicrelief/component-library/actions) | ||
| [](https://github.com/semantic-release/semantic-release) | ||
|
|
||
| React components to be shared across Comic Relief applications | ||
| ### Recent Rebuild Notes (June 2026): | ||
| - No more markdown importing Javascript faff in example files, just simple React component examples. | ||
| - Only exception is the code examples visible below each of the components - they are built using a Vite-specific import feature: | ||
| ```import buttonExampleSrc from '../components/Atoms/Button/ButtonExample.jsx?raw';``` | ||
| - Styled-Components 5 => Styled Components 6 - slight syntax change. Previously usage of nested selector / "&" usage in nested CSS was assumed. It now needs to be explicit (like normal native CSS). | ||
| - Removed _TriggerConfetti.js file. I couldn't find any usage, was likely a private helper no longer needed. | ||
|
|
||
| ### Use | ||
|
|
||
| CR-CL has a dependency of Styled-components. | ||
| ### General Usage | ||
| #### Main Dependencies | ||
| - Vite | ||
| - Styled Components | ||
|
|
||
| #### Install the package | ||
| ``` | ||
|
|
@@ -35,7 +43,7 @@ $ yarn install | |
|
|
||
| To start the dev build and server: | ||
| ``` | ||
| $ yarn styleguide | ||
| $ yarn dev | ||
| ``` | ||
|
|
||
| To test: | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Component Library</title> | ||
| </head> | ||
| <body> | ||
| <div id="root"></div> | ||
| <script type="module" src="/src/main.jsx"></script> | ||
| </body> | ||
| </html> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| [build] | ||
| command = "yarn build:preview" | ||
| publish = "dist" | ||
|
|
||
| [build.environment] | ||
| NODE_VERSION = "18" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shall we bump this to 22+, as per discussions today? |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per other comment re: Node 22+