Skip to content

Refactor: Migrate to reanimated 2#68

Open
ngocle2497 wants to merge 2 commits into
colorfy-software:mainfrom
ngocle2497:refact-Migrate-to-reanimated-2
Open

Refactor: Migrate to reanimated 2#68
ngocle2497 wants to merge 2 commits into
colorfy-software:mainfrom
ngocle2497:refact-Migrate-to-reanimated-2

Conversation

@ngocle2497
Copy link
Copy Markdown

This PR uses Reanimated 2 to be supported by JSI instead of Bridge

@CharlesMangwa
Copy link
Copy Markdown
Member

Hey @MasonLe2497! Thank you for this great PR! I've been thinking about switching Modalfy to Reanimated v2 for a long time, just was waiting to ship some other features & fixes before that. I'll go over your PR and try to get it merge as soon as I'll have a minute! 💪

@ngocle2497
Copy link
Copy Markdown
Author

I tested on android device, and it works with 60fps
https://user-images.githubusercontent.com/43195241/157888496-336df1f1-d2c0-4dad-aeb4-2abeb29b9c4d.mov

@ngocle2497
Copy link
Copy Markdown
Author

But with this PR, transitionOptions must be a 'worklet' function return ViewStyle

@CharlesMangwa
Copy link
Copy Markdown
Member

Yeah, I suspected that the switch to Reanimated 2 would be a breaking change and would require a major app update, shouldn't be much of an issue if the doc has proper migration guide.

@CharlesMangwa CharlesMangwa self-assigned this Mar 11, 2022
@CharlesMangwa CharlesMangwa added the new feature New feature or request label Mar 11, 2022
@LeviWilliams
Copy link
Copy Markdown

Hey! I'm looking into migrating to this library and v2 reanimated support is something on our list, is there any chance this is on the docket still? Love the lib design so far too nice work

@LeviWilliams
Copy link
Copy Markdown

@MasonLe2497 Thinking about patching this into my project, have you used in production at all? Thanks!

@tonihm96
Copy link
Copy Markdown

hey! is this still being worked on? I'd love to see modalfy having support for reanimated 😄

@CharlesMangwa
Copy link
Copy Markdown
Member

hi @tonihm96. no this is currently not being worked on. we'll try to keep you posted once this gets on top of our todo list 👍

@GaeCuure
Copy link
Copy Markdown

would love to see modalfy having support for reanimated !

@LukasMod
Copy link
Copy Markdown

Is the transition to reanimated still under consideration?

@rendomnet
Copy link
Copy Markdown

Will it migrate to reanimated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants