RFC: Nested failures fail, not raise#211
Open
exterm wants to merge 1 commit intocollectiveidea:masterfrom
Open
RFC: Nested failures fail, not raise#211exterm wants to merge 1 commit intocollectiveidea:masterfrom
exterm wants to merge 1 commit intocollectiveidea:masterfrom
Conversation
|
@gaffneyc I've been running the last released version and I had some issues with nested interactors. If you use With #170 it's a bit better, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been using this library for years, but only recently started adopting
call!for fast failures.We found that the behavior of a nested
call!vs afail!was surprising.E.g.
But,
We would have expected that
SomeInteractor.callshows the same behavior in both cases, catchingFailureand returning a context with failure status.I've attached a (very rough) example implementation in this PR.