Make the Context class swappable#174
Open
fnordfish wants to merge 2 commits intocollectiveidea:v4from
Open
Conversation
adding some minimalist docs so that rubocop is satisfied
Author
|
Specs are failing due to the development dependency on bundler |
Member
|
Thank you for the contribution and I'm sorry that it's taken so long to get eyes on it. Contexts being a big ball of randomly keyed values has been one of my biggest complaints with Interactor since 1.0. I like the idea of making the Context class configurable as part of a larger effort to make working with Contexts easier. I'm not sure yet what that looks like yet but it will be a focus of a 4.0 release at some point in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to have more control on how the context works. For example which attributes are required, it's default values or validation.
Here's a short sample for illustration:
This PR probably lacks quite some documentation etc. I just wanted to get your input if this is something you'd consider. (Obviously I'm happy to put more work into this if you do)