-
Notifications
You must be signed in to change notification settings - Fork 1
PFM-TASK-7221 - Restrict GitHub Actions workflow permissions #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PFM-TASK-7221 - Restrict GitHub Actions workflow permissions #116
Conversation
Replace overly permissive 'write-all' with specific permissions (contents, pull-requests, actions, checks) to follow security best practices and improve security rating. Affected files: - .github/workflow-templates/fe/fe-check-upmerge.yml - .github/workflow-templates/fe/fe-cleanup-snapshots.yml - .github/workflow-templates/fe/fe-licenses.yml - .github/workflow-templates/fe/fe-main.yml - .github/workflow-templates/fe/fe-pr-close.yml - .github/workflow-templates/fe/fe-pr-snapshot.yml - .github/workflow-templates/fe/fe-pr.yml - .github/workflow-templates/fe/fe-release.yml - .github/workflow-templates/fe/fe-tag-pushed.yml
| jobs: | ||
| check-upmerge: | ||
| uses: collaborationFactory/github-actions/.github/workflows/fe-check-upmerge.yml@release/26.1 | ||
| uses: collaborationFactory/github-actions/.github/workflows/fe-check-upmerge.yml@feature/PFM-TASK-7221-Restrict-GitHub-Actions-Workflow-Permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use release/26.1 instead of feature branch. Same in all files in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done by revert commit
slaven3kopic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check my comment
…po in dummy PR" This reverts commit a11c750.
Resolves PFM-TASK-7221
changelog: Frontend-Core: [PFM-TASK-7221] Functionality: Restrict GitHub Actions workflow permissions to follow least-privilege principle [PR github-actions#116]Summary
write-allpermissions with specific required permissions across all GitHub Actions workflow filesAffected Workflows
Workflow Templates (permissions: write-all → specific permissions)
.github/workflow-templates/fe/fe-check-upmerge.yml.github/workflow-templates/fe/fe-cleanup-snapshots.yml.github/workflow-templates/fe/fe-licenses.yml.github/workflow-templates/fe/fe-main.yml.github/workflow-templates/fe/fe-pr-close.yml.github/workflow-templates/fe/fe-pr-snapshot.yml.github/workflow-templates/fe/fe-pr.yml.github/workflow-templates/fe/fe-release.yml.github/workflow-templates/fe/fe-tag-pushed.ymlDeveloper Checklist: