Destroy FFMPEG WASM workers when the dispose lifecycle event happens#736
Open
nicolo-kira wants to merge 1 commit intocollab-project:masterfrom
Open
Destroy FFMPEG WASM workers when the dispose lifecycle event happens#736nicolo-kira wants to merge 1 commit intocollab-project:masterfrom
nicolo-kira wants to merge 1 commit intocollab-project:masterfrom
Conversation
nicolo-kira
force-pushed
the
fix-ffmpeg-wasm-leak
branch
from
e379bf6 to
b5d97e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our local application we noticed that if you run the ffmpeg-wasm convert engine multiple times in a row, even after calling the VideoJS
disposefunction, the plugin loads the ffmpeg workers into the browser on every conversion. This caused a memory leak and eventual crash in our application, as the number of workers trying to run kept growing and growingI've added a dispose hook in the convert engine similar to the record engine, which would be called when the player is disposed of, and cleans up the ffmpeg workers to avoid the memory leak.