Add mTLS with Temporal Cloud instructions#334
Open
aguynamedben wants to merge 1 commit intocoinbase:masterfrom
Open
Add mTLS with Temporal Cloud instructions#334aguynamedben wants to merge 1 commit intocoinbase:masterfrom
aguynamedben wants to merge 1 commit intocoinbase:masterfrom
Conversation
The "out of the box" SSL instructions didn't work for me because I used the option to create my own CA certificate and end-end entity certificates. I added a section to Authentication that makes it easy for people following along with the Temporal Cloud setup. If you create your own CA certificate, including the root certificate in the constructor of GRPC::Core::ChannelCredentials.new leads to auth failures, but the tests of that function ensure that it's okay to pass `nil` as that value, which is needed for people following the Temporal Cloud instructions. For developer happiness, I think it's also reasonable for this library to include Temporal Cloud-friendly instructions. (not a spokesperson!) :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "out of the box" SSL instructions didn't work for me because I used the option to create my own CA certificate and end-end entity certificates.
I added a section to Authentication that makes it easy for people following along with the Temporal Cloud setup. If you create your own CA certificate, including the root certificate in the constructor of GRPC::Core::ChannelCredentials.new leads to auth failures, but the tests of that function ensure that it's okay to pass
nilas that value, which is needed for people following the Temporal Cloud instructions.For developer happiness, I think it's also reasonable for this library to include Temporal Cloud-friendly instructions. (not a spokesperson!) :D