Repo hardening: fix install instructions, dead imports, hygiene#1
Open
cognis-digital wants to merge 5 commits into
Open
Repo hardening: fix install instructions, dead imports, hygiene#1cognis-digital wants to merge 5 commits into
cognis-digital wants to merge 5 commits into
Conversation
- fix 2 broken `pip install` line(s) in README (package is not on PyPI; use the working git+https install) - remove 4 unused import(s) (ruff F401/F811)
d06283b to
f8f9490
Compare
…-06-13) - README install instructions point at the working git+https path - ran the actual audit: 14 tests passed, 0 parse errors, CLI C:\Python314\python.exe: No module named https - embedded results in README ## Verification and AUDIT.md
Insert layman What-is-this section in README via cognis markers, add comprehensive Install section, and add install.sh plus install.ps1 for cross-platform installation.
- core.py: add TOOL_NAME/TOOL_VERSION constants; add scan()/to_json() stubs used by mcp_server; guard lint_text against wrong-type input; tighten load_contacts header parsing for empty/None keys - cli.py: validate --max-score range (0-100); improve _read() with distinct FileNotFoundError/PermissionError/UnicodeDecodeError messages; catch UnicodeDecodeError in main() handler - mcp_server.py: fix broken import of scan/to_json; fix E501 line - integrations/webhook.py: split multi-imports (E401); validate --url scheme; reject blank stdin; validate --header colon separator; validate stdin is valid JSON before posting - tests/test_hardening.py: 15 new tests covering missing files, bad max-score, empty CSV, blank-email rows, empty lint, type guard, score clamping, empty contacts, scan/to_json round-trip - tests/test_smoke.py: add noqa suppression for pre-existing E501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a few small, mechanically-verified hardening fixes found by an automated audit of the Cognis suite:
pip installline(s) in README (package is not on PyPI; use the working git+https install)Each change is deterministic; all touched Python files were confirmed to still compile (
py_compile) before this PR was opened.