Ati/cl 270 add email- number - price components to gooey (#45)#46
Merged
ati7697 merged 1 commit intoMay 21, 2026
Merged
Conversation
* Add Email, Text, Number, Price components Adds semantic form-input wrappers to bridge the gap with @codinglabsau/ui so LP form-builder schemas can port across cleanly. Price's v-model is a number in dollars (Intl-formatted display) — consumers never convert to cents. Description/error display is left to existing Field primitives. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Remove Text component Drops Text from src/components, library exports, and demo app. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * build * Fix Number/Price specs targeting the input directly cy.type() auto-walks into the inner input but leaves the subject on the wrapper div, so the chained cy.blur() fails — "can only be called on the focused element". Target [data-cy] input so type/blur/val all run against the focused input. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Fix Number integer-mode test assertion Integer mode strips the decimal separator on input rather than rounding on blur, so typing "7.5" produces 75, not 8. Assert that the displayed value is a whole number — the observable contract of integer mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds three new form components—
Email,Number, andPrice—to the codebase, along with their documentation pages, navigation entries, and Cypress tests. These components are now available for use, are documented in the app, and are included in the navigation and routing system.New Components and Features:
Added
Emailcomponent:src/components/email/Email.vue,src/components/email/index.ts,src/components/email/email.spec.ts)src/index.ts,app/pages/index.ts,app/router/index.ts,app/router/navigation.ts)app/pages/components/Email.vue)Added
Numbercomponent:src/components/number/Number.vue,src/components/number/index.ts,src/components/number/number.spec.ts)src/index.ts,app/pages/index.ts,app/router/index.ts,app/router/navigation.ts)app/pages/components/Number.vue)Added
Pricecomponent:src/components/price/Price.vue,src/components/price/index.ts,src/components/price/price.spec.ts)src/index.ts,app/pages/index.ts,app/router/index.ts,app/router/navigation.ts)app/pages/components/Price.vue)Documentation and Navigation:
Added new documentation pages for
Email,Number, andPricecomponents, including usage examples and code snippets (app/pages/components/Email.vue,app/pages/components/Number.vue,app/pages/components/Price.vue)Updated navigation and router configuration to include the new components, making them accessible via the app UI (
app/router/navigation.ts,app/router/index.ts)Testing:
Added Cypress tests for all three new components to verify rendering, v-model updates, and special behaviors (e.g., integer rounding, currency formatting) (
src/components/email/email.spec.ts,src/components/number/number.spec.ts,src/components/price/price.spec.ts)These changes significantly improve the form input capabilities of the app with modern, well-documented, and tested components.