Skip to content

dynamic_page_folder_element condition #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erral merged 3 commits into from
Oct 7, 2026
Merged

dynamic_page_folder_element condition #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f1576d
dynamic_page_folder_element element condition
libargutxi Oct 7, 2026
d833b54
changelog
libargutxi Oct 7, 2026
10f66f4
format and lint
libargutxi Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/+dynamic_page_folder_element.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix `dynamic_page_folder_element` handling in the dynamic page view, avoiding an extra call and using `nocall` to check its presence. @libargutxi
8 changes: 6 additions & 2 deletions src/cs_dynamicpages/views/dynamic_view.pt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@
<metal:main fill-slot="main">
<main id="dynamic_pages_content">

<tal:condition-configuration condition="view/dynamic_page_folder_element">
<tal:condition-configuration define="
dynamic_page_folder_element view/dynamic_page_folder_element;
"
condition="nocall:dynamic_page_folder_element"
>
<tal:conditiondrapanddrop tal:condition="view/can_edit">
<script id="sortable-js"
src="https://cdn.jsdelivr.net/npm/sortablejs@latest/Sortable.min.js"
Expand Down Expand Up @@ -581,7 +585,7 @@
<button class="btn btn-primary"
id="addAsTemplate"
type="button"
data-uid="${python:view.dynamic_page_folder_element().UID()}"
data-uid="${python:dynamic_page_folder_element.UID()}"
i18n:translate=""
>Save as
template</button>
Expand Down
Loading