Skip to content

test: SANDBOX-1826 - fix race condition in CreateSpaceRequest #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rsoaresd wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: SANDBOX-1826 - fix race condition in CreateSpaceRequest #1277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions test/e2e/usersignup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,10 @@ func (s *userSignupIntegrationTest) TestAutomaticApproval() {
domains := "anotherdomain.edu"
// when
hostAwait.UpdateToolchainConfig(s.T(), testconfig.AutomaticApproval().Enabled(true).Domains(domains), testconfig.RegistrationService().Verification().Enabled(false))
VerifyToolchainConfig(s.T(), hostAwait, wait.UntilToolchainConfigHasAutoApprovalDomains(domains), wait.UntilToolchainConfigHasVerificationEnabled(false))

VerifyToolchainConfig(s.T(), hostAwait,
wait.UntilToolchainConfigHasAutoApprovalDomains(domains),
wait.UntilToolchainConfigHasVerificationEnabled(false),
wait.UntilToolchainConfigHasSyncedStatus(wait.ToolchainConfigSyncComplete()))
Copy link
Copy Markdown
Contributor

@metlos metlos May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading the code of the toolchainconfig controller correctly, there is no "sync in progress" state or something like that, so the sync complete status might be there for the entirety of this test function. Could you please explain in more detail how does this additional check help the situation?

Copy link
Copy Markdown
Contributor Author

@rsoaresd rsoaresd May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrongly thought that wait.ToolchainConfigSyncComplete() proves that the controller reconciled 😭 I will try to think about other solution

Copy link
Copy Markdown
Contributor Author

@rsoaresd rsoaresd May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for raising that point!

// and
waitingListUser3 := NewSignupRequest(s.Awaitilities).
Username("waitinglist3").
Expand Down
Loading