Skip to content

config: update CodeRabbit config#1262

Open
rsoaresd wants to merge 6 commits intocodeready-toolchain:masterfrom
rsoaresd:clean_coderrabit_config_h
Open

config: update CodeRabbit config#1262
rsoaresd wants to merge 6 commits intocodeready-toolchain:masterfrom
rsoaresd:clean_coderrabit_config_h

Conversation

@rsoaresd
Copy link
Copy Markdown
Contributor

@rsoaresd rsoaresd commented May 5, 2026

Description

Previously, CodeRabbit Multi-Repo Analysis feature only allowed one linked repository, so we decided to address repository-config to have the "freedom" to choose the linked repo to each target repo, instead of linked the same repo to all the repositories across the organization - #1248 .

Since now CodeRabbit Multi-Repo Analysis feature allows linking more than one repository, we can start to use organization-wide configuration through CodeRabbit UI. Since toolchain-common will be linked in organization-wide configuration, we can clean it.

This PR also links member-operator and registration-service.

Assisted-by: Cursor

Issue ticket number and link

SANDBOX-1677

Summary by CodeRabbit

  • Chores
    • Updated linked-repository configuration: removed the existing toolchain-common entry and added two new linked repositories (registration-service and member-operator), each with repo-specific review instructions. Inheritance of settings remains enabled. Documentation and internal references updated accordingly.

@openshift-ci openshift-ci Bot requested review from alexeykazakov and mfrancisc May 5, 2026 09:55
@openshift-ci openshift-ci Bot added the approved label May 5, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2f8fdc90-ecb2-49ff-bcf9-6a5515210e53

📥 Commits

Reviewing files that changed from the base of the PR and between 93f1900 and 332ff54.

📒 Files selected for processing (1)
  • .coderabbit.yaml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: GolangCI Lint
  • GitHub Check: test
  • GitHub Check: Build & push operator bundles & dashboard image for e2e tests
🧰 Additional context used
🔀 Multi-repo context codeready-toolchain/registration-service, codeready-toolchain/member-operator, codeready-toolchain/api, codeready-toolchain/toolchain-common, codeready-toolchain/toolchain-e2e

[::codeready-toolchain/registration-service::]

  • go.mod requires toolchain-common v0.0.0-20260416204807-1fd670b5f220. [::codeready-toolchain/registration-service::go.mod:10]
  • Many imports of toolchain-common packages throughout code/tests (examples): pkg/signup/service/signup_service.go, pkg/proxy/proxy.go, pkg/verification/service_test.go, test/util/application.go, pkg/server/routes.go, pkg/namespaces/namespaces_manager.go. These indicate tight coupling to toolchain-common APIs and test helpers. [::codeready-toolchain/registration-service::pkg/signup/service/signup_service.go] [::codeready-toolchain/registration-service::pkg/proxy/proxy.go] [::codeready-toolchain/registration-service::pkg/verification/service_test.go] [::codeready-toolchain/registration-service::test/util/application.go] [::codeready-toolchain/registration-service::pkg/server/routes.go] [::codeready-toolchain/registration-service::pkg/namespaces/namespaces_manager.go]
  • Make/manifests and CI scripts reference registration-service deployment flows. [::codeready-toolchain/registration-service::make/manifests.mk] [::codeready-toolchain/registration-service::scripts/deploy-dev.sh]

[::codeready-toolchain/member-operator::]

  • go.mod requires toolchain-common v0.0.0-20260305144813-52d9242e8c74. [::codeready-toolchain/member-operator::go.mod:5]
  • Widespread imports of toolchain-common across controllers, webhooks, tests and deploy helpers (e.g., controllers/nstemplateset/, controllers/memberstatus/, pkg/webhook/mutatingwebhook/vm_mutate.go, pkg/autoscaler). These are direct consumers of shared types/utilities. [::codeready-toolchain/member-operator::controllers/nstemplateset/nstemplateset_controller.go] [::codeready-toolchain/member-operator::controllers/memberstatus/memberstatus_controller.go] [::codeready-toolchain/member-operator::pkg/webhook/mutatingwebhook/vm_mutate.go] [::codeready-toolchain/member-operator::pkg/autoscaler/autoscaler.go]
  • Manifests/CI reference member-operator for bundle/index publishing and e2e pairing. [::codeready-toolchain/member-operator::make/manifests.mk] [::codeready-toolchain/member-operator::README.adoc]

[::codeready-toolchain/api::]

  • Scripts dispatch CRDs into host-operator and member-operator and include registration-service and toolchain-common in verify-replace list. [::codeready-toolchain/api::scripts/verify-replace.sh] [::codeready-toolchain/api::make/generate.mk]
  • API types/docs annotate fields consumed by host/registration/member operators (toolchainconfig_types.go, memberoperatorconfig_types.go, memberstatus_types.go). Changes to these CRDs or field semantics are cross-repo breaking-change risks. [::codeready-toolchain/api::api/v1alpha1/toolchainconfig_types.go] [::codeready-toolchain/api::api/v1alpha1/memberoperatorconfig_types.go] [::codeready-toolchain/api::api/v1alpha1/memberstatus_types.go]

[::codeready-toolchain/toolchain-common::]

  • Contains its own .coderabbit.yaml and scripts (scripts/verify-replace.sh) to propagate go mod replace and run compatibility checks against dependent repos (host/member/registration/e2e). [::codeready-toolchain/toolchain-common::scripts/verify-replace.sh]
  • toolchain-common provides many shared packages and extensive test helpers referenced by registration-service, member-operator and toolchain-e2e (pkg/test, pkg/configuration, pkg/client, pkg/template, pkg/cluster, etc.). Any change in exported APIs here affects all dependents. [::codeready-toolchain/toolchain-common::pkg]

[::codeready-toolchain/toolchain-e2e::]

  • E2E tests depend on registration-service and member-operator (wait for deployments/routes/webhooks, metrics) and on toolchain-common test helpers. make/test targets assume local host/member/registration repos for running tests. [::codeready-toolchain/toolchain-e2e::testsupport/init.go] [::codeready-toolchain/toolchain-e2e::testsupport/wait/member.go] [::codeready-toolchain/toolchain-e2e::make/test.mk]

Conclusion:

  • The PR is a config-only change (CodeRabbit linked-repos) adding registration-service and member-operator and removing repo-specific toolchain-common entry. The explored repos confirm registration-service and member-operator are heavy consumers of toolchain-common and of API CRDs; moving to org-level CodeRabbit config is appropriate.
  • No code/API-breaking changes were discovered in this PR itself, but reviewers should be aware that any future changes to toolchain-common exports or API CRD fields will require coordinated updates across registration-service, member-operator, api, and toolchain-e2e (high coupling).
🔇 Additional comments (2)
.coderabbit.yaml (2)

4-13: Good update for registration-service cross-repo checks.

This instruction block is specific and actionable, and it aligns well with host-operator ↔ registration-service integration risks.


14-24: Good update for member-operator cross-repo checks.

These checks are concrete and cover the high-coupling areas (UserAccount/NSTemplateSet, ToolchainConfig/MemberOperatorConfig, status aggregation, RBAC, tier templates).


Walkthrough

The .coderabbit.yaml configuration's knowledge_base.linked_repositories list was changed: the codeready-toolchain/toolchain-common entry was removed and replaced by two entries—codeready-toolchain/registration-service and codeready-toolchain/member-operator—each with repository-specific review instructions. inheritance: true remains.

Changes

Knowledge Base Linked Repositories

Layer / File(s) Summary
Data Shape
.coderabbit.yaml
Removed knowledge_base.linked_repositories[]: codeready-toolchain/toolchain-common; added two entries: codeready-toolchain/registration-service and codeready-toolchain/member-operator.
Repository Instructions
.coderabbit.yaml
Each new linked repo includes its instructions block (registration-service: HTTP health/config/template review hints; member-operator: cross-cluster reconciliation/expected status-fields review hints).
Meta / Inheritance
.coderabbit.yaml
inheritance: true remains enabled; overall linked_repositories structure preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

agentic

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'config: update CodeRabbit config' accurately describes the main change—updating the CodeRabbit configuration file to replace linked repositories and enable multi-repo support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added chore Routine repo or tooling maintenance agentic Add or update AI agent configuration — CLAUDE.md, AGENTS.md, .claude/, .cursor/, or .coderabbit.yaml labels May 5, 2026
@rsoaresd rsoaresd changed the title clean CodeRabbit config config: clean CodeRabbit config May 5, 2026
@rsoaresd rsoaresd changed the title config: clean CodeRabbit config config: update CodeRabbit config May 5, 2026
@coderabbitai coderabbitai Bot removed chore Routine repo or tooling maintenance agentic Add or update AI agent configuration — CLAUDE.md, AGENTS.md, .claude/, .cursor/, or .coderabbit.yaml labels May 5, 2026
Comment thread .coderabbit.yaml
@coderabbitai coderabbitai Bot added the agentic Add or update AI agent configuration — CLAUDE.md, AGENTS.md, .claude/, .cursor/, or .coderabbit.yaml label May 5, 2026
Comment thread .coderabbit.yaml Outdated
instructions: |
member-operator runs on member clusters and reconciles resources host-operator creates cross-cluster.

When reviewing host-operator changes:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing.

It says "when reviewing host-operator changes:" but then describes what the host operator does.
Instead of instructing the agent what to do. Also, the agent should know what the operator does by looking at its codebase, rigth?
Same problem above.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your feedback! I refactored

@coderabbitai coderabbitai Bot removed the agentic Add or update AI agent configuration — CLAUDE.md, AGENTS.md, .claude/, .cursor/, or .coderabbit.yaml label May 6, 2026
@rsoaresd rsoaresd requested review from alexeykazakov and xcoulon May 6, 2026 10:29
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@rsoaresd
Copy link
Copy Markdown
Contributor Author

rsoaresd commented May 6, 2026

/retest

flaky test

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants