Skip to content

Remove JsonReader and JsonWriter - #124

Merged
Soar360 merged 1 commit into
mainfrom
remove-json-reader-writer
Aug 7, 2026
Merged

Remove JsonReader and JsonWriter#124
Soar360 merged 1 commit into
mainfrom
remove-json-reader-writer

Conversation

@Soar360

@Soar360 Soar360 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings August 7, 2026 03:41
@Soar360
Soar360 merged commit d385a66 into main Aug 7, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the project’s custom JSON reader/writer implementations from LuYao.Common (namespace LuYao.Text.Json) along with their dedicated unit tests, effectively eliminating these APIs from the library surface.

Changes:

  • Deleted JsonWriter implementation from LuYao.Common.
  • Deleted JsonReader implementation (including the custom JsonException type defined in that file).
  • Removed the corresponding unit test suites for JsonWriter and JsonReader.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/LuYao.Common.UnitTests/Text/Json/JsonWriterTests.cs Removed unit tests for the custom JsonWriter API.
tests/LuYao.Common.UnitTests/Text/Json/JsonReaderTest.cs Removed unit tests for the custom JsonReader API.
src/LuYao.Common/Text/Json/JsonWriter.cs Removed the public JsonWriter implementation (breaking API surface change).
src/LuYao.Common/Text/Json/JsonReader.cs Removed the public JsonReader implementation and the custom JsonException type (breaking API surface change).
Suppressed comments (2)

src/LuYao.Common/Text/Json/JsonReader.cs:1

  • Removing the public JsonReader (and the LuYao.Text.Json.JsonException type defined in the same file) is a breaking change for library consumers and can also change exception contracts. If the intent is to standardize on System.Text.Json, consider leaving compatibility shims marked [Obsolete] for at least one release, or ensure the package versioning and migration notes explicitly call out these removals.
    src/LuYao.Common/Text/Json/JsonWriter.cs:1
  • Removing the public JsonWriter API from LuYao.Common is a breaking change for any downstream consumers that used LuYao.Text.Json.JsonWriter. If this removal is intentional, consider providing a transition path (e.g., keep a thin wrapper marked [Obsolete] that delegates to System.Text.Json/Newtonsoft, or postpone removal to a major-version bump and document it in release notes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants