Remove server version from header#3
Open
samuelcatalan-sketch wants to merge 4 commits into
Open
Conversation
lee-harmonic
reviewed
Dec 2, 2025
| from twisted.logger import STDLibLogObserver # type: ignore | ||
| from twisted.python import threadpool # type: ignore | ||
| from twisted.web.http import Request, proxiedLogFormatter # type: ignore | ||
| import twisted.web.http |
lee-harmonic
approved these changes
Dec 11, 2025
|
@coderanger A pentest suggested this change and this is the most pragmatic way to achieve it. There is an open issue in Twisted for this from many years ago with no indication that they will fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a --hide-server header flag when executing from command line
Can keep server version when wanting to develop or debug, but can hide it from headers for security reasons