🤖 refactor: stream bounded history message readability evidence - #4219
🤖 refactor: stream bounded history message readability evidence#4219ThomasK33 wants to merge 1 commit into
Conversation
|
@codex review Please review the current head. This remains part of the cancellation phase and will merge only with the completed, approved, green phase. Generated with |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with `xum` • Model: `unavailable` • Thinking: `unavailable` • Cost: `$unavailable`_ <!-- mux-attribution: model=unavailable thinking=unavailable costs=unavailable --> Change-Id: I45348d9e8fc671a388991db7fdeb7e71839147bb
6491740 to
b85b162
Compare
|
@codex review Please review the current head after the complete phase was composed on current main. All known findings have fixes and replies in their owning layers; the eight-member phase stays held until all members are approved and green. Generated with |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Adds streamed message-readability evidence above the scalar reader in #4215. Oversized history rows need the same identity and readability decisions as ordinary JSON.parse rows without retaining entire message payloads. This prerequisite provides those facts; the separate row adapter and #4182 integration will consume them.
The projection checks every part and workflow element against the existing schema fragments, including constrained strings, finite numbers, strict objects, array limits and ordered workflow events. It preserves legacy role coercion, duplicate-key behavior and normalization detection. Scalar retention is bounded; nesting and distinct object-key bookkeeping retain the raw reader's documented limits. There is no persistence change or replacement authority decision in this layer.
Validation: 100 reader/scalar/projection tests with 7,316 assertions passed on the reviewed projection source; a Node 22 native oracle passed 117 checks across 60 rows, including an 8 MiB fixture. Independent review compared 48 additional native cases. Canonical static checks passed. The final publication includes the reviewed scanner callback/cancellation fixes beneath this layer; all 109 combined tests / 7,339 assertions pass.
Risk: projection drift from the ordinary reader could change which historical messages count as readable. The implementation deliberately uses the current schema fragments and native-comparison tests; activation stays in the separately reviewed adapter/integration change.
Final phase integration on main
ad8a01b: independent composition review and full canonical static checks pass on tree3ed04896. Across 35 affected files, 2,549 tests / 28,590 assertions pass: 34 files passed before a test-only lifecycle repair, then all 28 pinned-budget tests passed after it. Two final-flush fixtures now complete their fake stream on Stop instead of waiting for later disposal; their original assertions and production behavior are unchanged.The complete cancellation phase is ordered #4214 → #4215 → #4219 → #4221 → #4182 → #4187 → #4191 → #4209. The reader prerequisites and runtime changes merge together only after every member has current-head approval and green CI.
Generated with
xum• Model:unavailable• Thinking:unavailable• Cost:$unavailable