Repository navigation
Conversation
…left open The reviews of #890 and #892 left five mutants alive. The grep test now puts the bad entry first, in the middle and last; bare "/" entries count against the budget as sent; a diff, branches/diff or blame list over the budget with a blank or outside entry answers that entry's own message; and an over-limit username next to a short valid password is refused. Each of those mutants now fails. The api README lists the sync limits, and the gcredValidate comment says that each value, not the entry, must fit MaxCredentialBytes. Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_ Change-Id: Ia0f1e0a1b12c06ce68ca921178f1e7621044255d
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…pository lookup The review found that moving the blame list check after the repository lookup passed every test: nothing pinned "400 before git starts" for a list. Each list route now gets a list over the budget for a repository that does not exist, and must answer the list 400, not 404. Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_ Change-Id: If971c15d9dde27a97e9a4961f945cb775f54820c
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
The reviews of #890 and #892 left five mutants of their checks alive. This PR adds the test cases that kill them, plus a README line and a comment fix that the #892 review asked for. No behavior change.
paths.Nbadset only for entry 0 (M23)/counts against the budget/entries answer 200, 1,986 answer the list 400 (each counts 1 + 32 bytes)cleanPathParams(M24, M24b), or in the blame entry loop (after the length check, or inside the blank branch)resolveQueryRepousernamenext to a short valid passwordusernameinternal/api/README.mdgets a line for the limits that fix(api): refuse a sync link or credential that git cannot take when it is stored #892 added at registration, citingupstreamURLProblem,validateSyncBaseRepoandgcredValidate.gcredValidatecomment now says that each value must be at mostupsync.MaxCredentialBytes(it said the environment entry must fit it).Evidence
go test -overlayand failsTestReadValueListsPastGitArgBudgetorTestSyncValuesGitCannotTakeAtRegistration; a no-op control passes.go test -race -tags=openstorage_viewcheck ./internal/api/...without pg passes at 0c5fcf8 (370 s; 371 s at c6cf70e). PostgreSQL and S3-WAL rely on CI. Both fingerprint gates pass.Desk follow-up to the reviews of #890 and #892.
Review
/grep entry matches no file, asdocs/reference/http-api.mdsays; the 1,985-entry case pins that answer as well as the budget boundary.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:xhigh