Repository navigation
Conversation
The push-upstream bullet of http-api.md and the comment at the top of internal/sync/worker_push.go named only the deprecated push-only OPENSTORAGE_SYNC_PUSH_ALLOW_PRIVATE. The server reads it only while OPENSTORAGE_SYNC_ALLOW_PRIVATE is unset (cmd/openstorage/config.go, resolveSyncEgress). Both now name the unified variable first and say when the deprecated one is ignored. configuration.md adds that a malformed deprecated value still stops serve at startup. Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_ Change-Id: Icc90d2223ca5ef62c7d670edcf60627625922f20
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b15a58fcd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…guard does The review found the new sentence wrong both ways: true also admits RFC 6598 shared addresses (100.64.0.0/10), and the guard keeps only the two metadata addresses 169.254.169.254 and fd00:ec2::254 denied, not every metadata-looking range. http-api.md and configuration.md now use the wording of the webhook guard docs. An empty OPENSTORAGE_SYNC_ALLOW_PRIVATE counts as unset (resolveSyncEgress), so the docs say "unset or empty" and "has a value", and the worker_push.go comment says that the opt-in admits only the private classes. Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_ Change-Id: If5312b03db725222ca4fd8192063401075ae2ed3
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…y value is unset The second review found the wording still loose: "the cloud-metadata addresses" read as every metadata endpoint, "has a value" clashed with configuration.md's own word for an empty value, and "the deprecated variable is ignored" hid that serve still parses it. The docs now say that only two metadata addresses stay denied, that an empty unified value counts as unset, and that only the deprecated value is ignored. TestResolveSyncEgress pins the empty case. Two older lines get the same fixes: the table row at the top of configuration.md and the resolveSyncEgress line of cmd/openstorage/README.md. Signed-off-by: Thomas Kosiewski <tk@coder.com> --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_ Change-Id: Ia4e3302fa18b814fd329fadac6b70c067d57f09e
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
The docs and one code comment named only the deprecated
OPENSTORAGE_SYNC_PUSH_ALLOW_PRIVATEfor push destinations. The server always parses that variable, but uses its value only whileOPENSTORAGE_SYNC_ALLOW_PRIVATEis unset or empty (cmd/openstorage/config.go,resolveSyncEgress): when the unified variable is set, it decides both directions.What changes
docs/reference/http-api.md, push-upstream bullet: namesOPENSTORAGE_SYNC_ALLOW_PRIVATEfirst and whattrueadmits, in the wording of the webhook guard docs: loopback, RFC 1918, RFC 6598 shared, link-local and ULA addresses, while the cloud-metadata addresses (169.254.169.254,fd00:ec2::254) and the other IANA special-purpose ranges stay denied (internal/events/guard.go,deniedReason). The deprecated variable counts only while the unified one is unset or empty, and is ignored when it has a value.docs/reference/http-api.md, egress policy section: the same sentence about the deprecated variable.docs/reference/configuration.md: thetruevalue ofOPENSTORAGE_SYNC_ALLOW_PRIVATEgets the same admit list (it left out RFC 6598 shared space and said that every cloud-metadata range stays denied), "unset" reads "unset or empty", and the deprecated variable's value is ignored when the unified one is set, but a malformed value still stopsserveat startup.resolveSyncEgressparses it first, andTestResolveSyncEgresspins "malformed legacy is a boot error even when losing" (cmd/openstorage/config_test.go:1386at the head).internal/sync/worker_push.go, file comment: names the unified variable and the deprecated one's rule. This is a comment only, so the lane-schedule fingerprints do not change (the fingerprint gates pass).No behavior change.
The second review (2503995) passed with wording points; d379114 says that only two metadata addresses stay denied (a metadata endpoint inside an admitted range, such as
100.100.100.200, is admitted), uses "non-empty value" where configuration.md calls""an empty value, says that only the deprecated variable's value is ignored, fixes the table row at the top of configuration.md and theresolveSyncEgressline ofcmd/openstorage/README.md, and adds aTestResolveSyncEgresscase for an empty unified value.The review of the first head (b15a58f) found the admit list wrong both ways and the "unset" wording inexact (
resolveSyncEgresstreats an empty value as unset); 2503995 fixes both. Not changed here: code comments ininternal/events/guard.go,cmd/openstorage/config.go,internal/sync/worker.goandcmd/openstorage/wire_eventing.go, and the boot warning text incmd/openstorage/wire.go, still leave RFC 6598 shared space out of the admit list.Left open (P3, Codex reviews used up)
TestResolveSyncEgresscase passes the resolver the same input as an absent key; no test checks an empty-but-presentOPENSTORAGE_SYNC_ALLOW_PRIVATEthroughresolveServeConfig.2000::/3and zone-scoped literals are denied too.configuration.md, theguard.gocomment and ADR-45 still say the guard blocks cloud metadata in general; the sync section now says that100.100.100.200is admitted under the same guard.true; the admit list is spelled out only undertrue.Verification
git grep -n SYNC_PUSH_ALLOW_PRIVATEoutsidecmd/openstoragenow finds the variable only next to the unified one or in its ownconfiguration.mdsection, apart from ADR-44, which records the push-only design before ADR-45 unified it.scripts/check-doc-links.py,unittest discover -s scripts),go vet ./internal/sync, gofmt and both fingerprint gates pass.Found by the review of #889 (desk follow-up).
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:xhigh