🤖 fix: keep analytics sidebar controllable on mobile#3740
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95ca1f1267
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed Codex's persisted-state finding: the phone story now seeds the sidebar state through |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Resolved the repeated The test previously depended on a live model choosing and completing a Validated with three consecutive targeted passes plus @codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Keeps the left sidebar controllable from the Analytics route at narrow widths. Analytics previously hid its sidebar opener below the
mdbreakpoint even though the collapsed sidebar is fully off-canvas there, leaving no pointer-accessible way to reopen it.Implementation
mobile-menu-btnresponsive behavior used by other main-pane routes.bash.Validation
TEST_INTEGRATION=1 bun x jest tests/ui/layout/analyticsHeader.test.ts --runInBand --silentmake static-checkmake storybook-buildSTORYBOOK_PORT=6108 make storybook-run CMD='bun x test-storybook --url http://127.0.0.1:6108 --testTimeout 30000 --maxWorkers 1 src/browser/stories/App.phoneViewports.stories.tsx'Risks
Low. The production change only adds the existing responsive utility class to one route-specific button. Desktop behavior is unchanged. The test-only flake fix preserves the same WorkspaceStore event path while removing live-provider tool-selection variance.
Generated with
mux• Model:openai:gpt-5.6-sol• Thinking:high• Cost:$23.02