Repository navigation
Conversation
The Developer ID Application and Installer keys now live in Google Cloud KMS. Apple's codesign can't use them, so release.yml builds the app unsigned on macOS, signs it on Linux with rcodesign through the Cloud KMS PKCS#11 library, packages it on macOS, then signs, notarizes and staples the installer on Linux. The signing jobs run in the signing environment, the only one the desktop-macos-signer identity trusts. Notarization uses an App Store Connect API key instead of an Apple ID password, and the public certificates and release entitlements are committed in signing/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apple issues the Developer ID Installer certificate for the same Cloud KMS key as the Application certificate, so both signing steps select developer-id-application and only the certificate differs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ficate Keep the Developer ID Installer key in the PKCS#12 it already ships in, moved to the signing environment; only the Developer ID Application key is in Cloud KMS. rcodesign only reads legacy-encrypted PKCS#12 files, so sign.sh re-encodes the file with openssl first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signs the Coder Desktop app with the Developer ID Application key coder/coder already uses, which lives in Google Cloud KMS (
apple-codesign/developer-id-application), instead of the PKCS#12 in repository secrets. The.pkgkeeps its existing Developer ID Installer certificate, moved from repository secrets to thesigningenvironment.How
Apple's
codesigncan't use a Cloud KMS key, and the Cloud KMS PKCS#11 library only ships for Linux, sorelease.ymlalternates between macOS and Linux:buildCODE_SIGNING_ALLOWED=NO) and embeds the provisioning profilesrcodesignsign-appsigningenvscripts/sign.sh app: Developer ID Application key in KMSpackagecodesign(including the Helper's XPC requirement), thenpkgbuildsign-pkgsigningenvscripts/sign.sh pkg: existing Developer ID Installer PKCS#12;scripts/notarize.sh: notarize and staplepublishsigningenvpkgutil/stapler/spctlchecks, Sparkle signature, release assets, appcastscripts/sign.sh appreproduces Xcode's Developer ID export:signing/entitlements/. Those are copied from v0.8.5.I checked this by taking the v0.8.5 app, stripping the signatures from Coder's binaries and signing it with
sign.shand a throwaway certificate:The designated requirements still pin team
4399GN35BJ, so Sparkle updates, the system extension and the Helper's XPC check are unaffected.scripts/sign.sh pkgre-signs apkgbuildoutput with the PKCS#12. rcodesign only reads legacy-encrypted PKCS#12 files, so the script re-encodes the file with openssl first. I tested it with both modern and legacy PKCS#12 files.Other changes:
sign_updatecomes from Sparkle 2.7.0's SwiftPM zip, checked against the checksum in Sparkle'sPackage.swift.signing/.make releasenow builds an unsigned app, with no keychain.Before merging
desktop-macos-signeridentity that only this workflow can use, in thesigningenvironment, onmainor a publishedvX.Y.Zrelease.signingenvironment (mainandv*tags).signingenvironment:APPLE_INSTALLER_PKCS12_B64andAPPLE_INSTALLER_PKCS12_PASSWORD: the existing Installer certificate, from 1Password;AC_APIKEY_ISSUER_ID,AC_APIKEY_IDandAC_APIKEY_P8_BASE64: the same App Store Connect key coder/coder uses;SPARKLE_PRIVATE_KEY.After merging, run
releaseonmainwith dryrun, check the artifact, then delete these repository secrets:APPLE_DEVELOPER_ID_PKCS12_B64andAPPLE_DEVELOPER_ID_PKCS12_PASSWORDAPPLE_INSTALLER_PKCS12_B64andAPPLE_INSTALLER_PKCS12_PASSWORD(the copies now in the environment replace them)APPLE_NOTARYTOOL_USERNAMEandAPPLE_NOTARYTOOL_PASSWORDSPARKLE_PRIVATE_KEYDry runs now only sign from
main.🤖 Generated with Claude Code