Repository navigation
feat(adapters/slack): add Sign in with Slack and block_actions types to slackapi - #167
Conversation
…n values, and block_actions payloads
…very decoded field Use a nonce that encodes to the base64url-only "-" so the ID token test fails if the decoder uses the standard alphabet, add refresh_token and expires_in to the token response, give the interaction user a distinct name, and add an ephemeral-message block_actions case with is_ephemeral true and no message.
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3cacac4c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review I declined the PKCE finding on |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Simulated maintainer review. An agent wrote this in the style of ThomasK33's past maintainer reviews on this repo. It is not from a maintainer. I accept the direction. Sign in with Slack and typed Local check: Before merge:
Not blocking:
After that, the normal gate applies: green CI, a clean Codex code review and a clean Codex security review on the final head (pushes reset both), and zero unresolved threads. |
…kActions and the ID token check skip Add InteractionContainer.ThreadTS, so the thread of an ephemeral message is not lost when Message is nil. Say that BlockAction has only the fields of a button action. Say that OpenIDConnectToken checks the audience, team ID, and user ID, and does not check the signature, issuer, expiry, or nonce.
|
@codex review |
|
@codex security review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 267ef0fcfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
The Coder Agents Slack bot needs a few more things from
slackapibefore it can link Slack users to Coder users and handle button clicks, so this adds them.OpenIDConnectTokencallsopenid.connect.tokento finish Sign in with Slack, and decodes the Slack user ID and team ID from the ID token.Manifestgainsoauth_config.scopes.user,ButtonElementgains avalue, andParseBlockActionsdecodes ablock_actionsinteraction payload into typed fields, where before you only had the raw payload.The ID token's signature isn't checked, since it comes straight from Slack's token endpoint over TLS, which OpenID Connect allows. It does check that the audience is the client ID and that the token has a user and team ID, but it leaves the issuer alone so GovSlack works, and leaves the expiry and nonce to the caller. Like #113, I've only tested these against
slackapitestso far.