fix: add sessionId to UnstableCreateElicitationForm and UnstableCreateElicitationUrl - #51
Open
monsterxx03 wants to merge 1 commit into
Open
fix: add sessionId to UnstableCreateElicitationForm and UnstableCreateElicitationUrl#51monsterxx03 wants to merge 1 commit into
monsterxx03 wants to merge 1 commit into
Conversation
monsterxx03
force-pushed
the
fix/elicitation-sessionid
branch
from
July 23, 2026 09:18
d17da56 to
d43b1a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zed recently enabled ACP elicitations by default zed-industries/zed#60749, removing the beta feature flag that previously gated them. As part of this change, elicitation requests in
the ACP protocol are scoped by sessionId — the session the elicitation is tied to.
However, the UnstableCreateElicitationForm and UnstableCreateElicitationUrl types in acp-go-sdk were missing the sessionId field, making it impossible for Go-based ACP agents to correctly handle or
emit session-scoped elicitation requests that clients like Zed now expect.
This PR adds the optional sessionId field to both elicitation variant types and the corresponding JSON schema, aligning the Go SDK with the protocol shape used by Zed and other conforming ACP clients.